-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeAOT doesnt have a way to remove all occurences of an attribute #80466
Comments
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsDescriptionILLink has the option of using a wildcard Reproduction StepsSystem.Private.CoreLib actually declares a LinkAttributes xml file with this pattern https://github.com/dotnet/runtime/blob/main/src/mono/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.xml#L10-L15 Expected behaviorThe attribute is removed from all the assemblies Actual behaviorThe attribute is kept Regression?No response Known WorkaroundsNo response ConfigurationNo response Other informationNo response
|
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue DetailsDescriptionILLink has the option of using a wildcard Reproduction StepsSystem.Private.CoreLib actually declares a LinkAttributes xml file with this pattern https://github.com/dotnet/runtime/blob/main/src/mono/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.xml#L10-L15 Expected behaviorThe attribute is removed from all the assemblies Actual behaviorThe attribute is kept Regression?No response Known WorkaroundsNo response ConfigurationNo response Other informationNo response
|
We already track this in #77753. |
Description
ILLink has the option of using a wildcard
*
when processing LinkAttributes xml files. This allows removing an attribute existing in System.Private.CoreLib from all input assemblies (including System.Private.CoreLib). The way ILLink does this is by using its context to remember which attribute needs to be removed. NativeAOT doesnt have access to this context that coul allow to remember which attribute needs to be removed from other assemblies, therefore NativeAOT currently does not support the*
wildcardReproduction Steps
System.Private.CoreLib actually declares a LinkAttributes xml file with this pattern https://github.com/dotnet/runtime/blob/main/src/mono/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.xml#L10-L15
Expected behavior
The attribute is removed from all the assemblies
Actual behavior
The attribute is kept
Regression?
No response
Known Workarounds
No response
Configuration
No response
Other information
No response
The text was updated successfully, but these errors were encountered: