Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of InterceptorsPreview feature after updating to 8.0 RC2 SDK #92248

Closed
mthalman opened this issue Sep 18, 2023 · 2 comments · Fixed by #93940
Closed

Remove usage of InterceptorsPreview feature after updating to 8.0 RC2 SDK #92248

mthalman opened this issue Sep 18, 2023 · 2 comments · Fixed by #93940
Assignees
@ericstj
Labels
area-Extensions-Configuration tracking This issue is tracking the completion of other related issues.
Milestone
8.0.0

Comments

@mthalman
Copy link
Member

Once the runtime repo has been updated to use 8.0 RC2 SDK, the usage of the InterceptorsPreview feature can be removed from Microsoft.Extensions. See the changes in #92247 that indicate what needs to be removed.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 18, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Once the runtime repo has been updated to use 8.0 RC2 SDK, the usage of the InterceptorsPreview feature can be removed from Microsoft.Extensions. See the changes in #92247 that indicate what needs to be removed.

Author: mthalman
Assignees: -
Labels:

untriaged, area-Extensions-Configuration, needs-area-label
Milestone: -

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 18, 2023
@ericstj ericstj added tracking This issue is tracking the completion of other related issues. and removed untriaged New issue has not been triaged by the area owner labels Sep 19, 2023
@ericstj ericstj added this to the 8.0.0 milestone Sep 19, 2023
@ericstj
Copy link
Member

ericstj commented Sep 19, 2023

Marked this as a tracking issue to remind us to cleanup the source. This isn't blocking release and these settings don't leak to customers in the product, but would be nice to clean up.

@ericstj ericstj mentioned this issue Oct 24, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 24, 2023
@ericstj ericstj self-assigned this Oct 24, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ericstj ericstj

Labels
area-Extensions-Configuration tracking This issue is tracking the completion of other related issues.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Remove use of InterceptorsPreview feature setting now that we build with RC2 ericstj/runtime
3 participants
@vcsjones @ericstj @mthalman