Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THIRD-PARTY-NOTICES.TXT needed for SDK repo? #24542

Closed
leecow opened this issue Mar 24, 2022 · 12 comments
Closed

THIRD-PARTY-NOTICES.TXT needed for SDK repo? #24542

leecow opened this issue Mar 24, 2022 · 12 comments
Assignees
Milestone

Comments

@leecow
Copy link
Member

leecow commented Mar 24, 2022

If third-party components are used in a .NET repo, a THIRD-PARTY-NOTICES.TXT detailing any third-party source code included in final built artifacts, along with the controlling license information must be included and maintained at the root of the affected repo (dotnet/runtime example).

During product build, these files are used to create a unified TPN file and included in the final installer builds (example) and source-build offerings.

Some repos will not need this notice as no third-party code is included in the final build artifacts.

Tracking issue: dotnet/runtime#61466

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Mar 24, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT added this to the Discussion milestone Mar 24, 2022
@leecow
Copy link
Member Author

leecow commented Mar 24, 2022

If the installer TPN already covers everything from /sdk then, yes, that would be sufficient.

@leecow
Copy link
Member Author

leecow commented Mar 25, 2022

@marcpopMSFT - can you confirm the Installer TPN covers the SDK as well? If so, I'll close this issue and make a note of it.

@marcpopMSFT
Copy link
Member

@leecow I assumed it did but I haven't done an analysis as I don't know what other dependencies other teams might have added into the SDK. Does the SBOM provide that?

@leecow
Copy link
Member Author

leecow commented Mar 28, 2022

I don't know @mmitche , do you know if SBOM include 3rd party info?

@mmitche
Copy link
Member

mmitche commented Mar 28, 2022

The SBOM will include some level of third party info for the installer official build pipeline (since those third party dependencies are restored in the build). But it doesn't necessarily know what is third party, what is not, what is used in the build vs. redistributed, etc.

@marcpopMSFT
Copy link
Member

@leecow so is the ask then to look through the SBOM, compare with installer 3rd party notices, and add anything that's missing?

@mmitche where in the CI build drop is the SBOM produced?

@mmitche
Copy link
Member

mmitche commented Mar 31, 2022

@leecow
Copy link
Member Author

leecow commented Mar 31, 2022

@marcpopMSFT, yes, that should satisfy the requirement.

@marcpopMSFT
Copy link
Member

Analysis has been done and shared with @leecow offline for follow-up.

@marcpopMSFT marcpopMSFT removed the untriaged Request triage from a team member label Jul 12, 2022
@leecow
Copy link
Member Author

leecow commented Aug 16, 2022

Looks like SDK is good to go. Closing this tracking issue.

@leecow leecow closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants