Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve templates #7695

Open
Tracked by #8674
RussKie opened this issue Aug 30, 2022 · 0 comments
Open
Tracked by #8674

Improve templates #7695

RussKie opened this issue Aug 30, 2022 · 0 comments

Comments

@RussKie
Copy link
Member

RussKie commented Aug 30, 2022

Issue description

As per dotnet/wpf#6973 (comment), we need to invert these conditions (dotnet/sdk#27486) as we missed a version in the past:

    "csharp9orOlder": {
      "type": "generated",
      "generator": "regexMatch",
      "datatype": "bool",
      "parameters": {
        "pattern": "^(ISO-1|ISO-2|[1-7]|[8-9]|[8-9]\\.0|7\\.[0-3])$",
        "source": "langVersion"
      }
    },
    "csharp8orOlder": {
      "type": "generated",
      "generator": "regexMatch",
      "datatype": "bool",
      "parameters": {
        "pattern": "^(ISO-1|ISO-2|[1-7]|8|8\\.0|7\\.[0-3])$",
        "source": "langVersion"
      }
    },
    "csharp7orOlder": {
      "type": "generated",
      "generator": "regexMatch",
      "datatype": "bool",
      "parameters": {
        "pattern": "^(ISO-1|ISO-2|[1-7]|7\\.[0-3])$",
        "source": "langVersion"
      }
    },

@RussKie RussKie added area-Templates untriaged The team needs to look at this issue in the next triage labels Aug 30, 2022
@RussKie RussKie added this to the .NET 8.0 milestone Aug 30, 2022
@merriemcgaw merriemcgaw removed the untriaged The team needs to look at this issue in the next triage label Aug 30, 2022
@merriemcgaw merriemcgaw modified the milestones: .NET 8.0, 8.0 Preview1 Aug 30, 2022
@merriemcgaw merriemcgaw removed this from the 8.0 Preview3 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants