ToolboxBitmapAttribute no longer supports resource/assembly name Suffixes #8832
Comments
|
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsWith dotnet/runtime#22761 and dotnet/corefx#22833, BitmapSelector.Suffix will always be null, with no external way of setting it to anything else. The implementation of the suffix feature tries looking for the following attributes on an assembly:
However, since the Suffix will only ever be Thus, the We should either add back support for
|
dotnet-issue-labeler
bot
added
the
untriaged
With dotnet#22761 and dotnet/corefx#22833, BitmapSelector.Suffix will always be null. This means this feature is dead code, and users are unable to use it. Removing this dead code because: 1. It doesn't do anything. 2. It is causing ILLink warnings, and it is easier to delete than to try to address the warnings. I logged https://github.com/dotnet/runtime/issues/54363 to follow up and either re-implement this feature, or obsolete the attributes that no longer have any effect on the app.
safern
removed
the
untriaged
With #22761 and dotnet/corefx#22833, BitmapSelector.Suffix will always be null. This means this feature is dead code, and users are unable to use it. Removing this dead code because: 1. It doesn't do anything. 2. It is causing ILLink warnings, and it is easier to delete than to try to address the warnings. I logged https://github.com/dotnet/runtime/issues/54363 to follow up and either re-implement this feature, or obsolete the attributes that no longer have any effect on the app.
With dotnet/runtime#22761 and dotnet/corefx#22833, BitmapSelector.Suffix will always be null. This means this feature is dead code, and users are unable to use it. Removing this dead code because: 1. It doesn't do anything. 2. It is causing ILLink warnings, and it is easier to delete than to try to address the warnings. I logged https://github.com/dotnet/runtime/issues/54363 to follow up and either re-implement this feature, or obsolete the attributes that no longer have any effect on the app. Commit migrated from dotnet/runtime@9199eb6
With dotnet/runtime#22761 and dotnet/corefx#22833, BitmapSelector.Suffix will always be null, with no external way of setting it to anything else.
https://github.com/dotnet/runtime/blob/1306b036c1414afa39608ed8ede24fe003191132/src/libraries/System.Drawing.Common/src/System/Drawing/BitmapSelector.cs#L15-L38
The implementation of the suffix feature tries looking for the following attributes on an assembly:
However, since the Suffix will only ever be
null, these attributes have no effect. Even if they are applied to an assembly, since the Suffix will always benull, nothing gets appended to the names:https://github.com/dotnet/runtime/blob/1306b036c1414afa39608ed8ede24fe003191132/src/libraries/System.Drawing.Common/src/System/Drawing/BitmapSelector.cs#L144-L185
Thus, the
originalNameis only ever used, and the attributes didn't do anything.We should either add back support for
Suffixhere, or we should[Obsolete]these attributes, since they don't do anything.NOTE: I am removing all this dead code in dotnet/runtime#54364. We can add it back if necessary in the future.
cc @safern @JeremyKuhne
The text was updated successfully, but these errors were encountered: