Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache masks computed during regex guidance #239

Closed
brandonwillard opened this issue Aug 16, 2023 · 0 comments · Fixed by #272
Closed

Cache masks computed during regex guidance #239

brandonwillard opened this issue Aug 16, 2023 · 0 comments · Fixed by #272
Labels
enhancement optimization Related to performance optimizations structured generation Linked to structured generation

Comments

@brandonwillard
Copy link
Member

This has come up a few times, but we apparently haven't created an issue for it: we can keep the masks in the "index" we build instead of the vocab indices. That will save on allocation time.

@brandonwillard brandonwillard added enhancement optimization Related to performance optimizations structured generation Linked to structured generation labels Aug 16, 2023
@brandonwillard brandonwillard changed the title Store the masks in the index Cache masks computed during regex guidance Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement optimization Related to performance optimizations structured generation Linked to structured generation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant