Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material design css not working #147

Closed
xporium opened this issue Aug 9, 2018 · 10 comments
Closed

material design css not working #147

xporium opened this issue Aug 9, 2018 · 10 comments
Labels

Comments

@xporium
Copy link

xporium commented Aug 9, 2018

hi,
i m new in react, actually i follow your steps and install react dropdown tree select in my project.
even i also added webpack rule which mentioned.
But if i try with custom css like material or bootstrap than its not working.
if i remove rule from webpack than default css also not working
so can any one tell me which rule or configuration i have to add in webpack?

i{
test: /.css$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: [
{
loader: 'css-loader'
}
]
}),
include: /node_modules[/\]react-dropdown-tree-select/
},
{
test: /.css$/,
use: [
require.resolve('style-loader'),
{
loader: require.resolve('css-loader'),
options: {
importLoaders: 1,
modules:true,
localIdentName:'[Name][local][has:base64:5]'
},
},
{
loader: require.resolve('postcss-loader'),
options: {
// Necessary for external CSS imports to work
// https://github.com/facebook/create-react-app/issues/2677
ident: 'postcss',
plugins: () => [
require('postcss-flexbugs-fixes'),
autoprefixer({
browsers: [
'>1%',
'last 4 versions',
'Firefox ESR',
'not ie < 9', // React doesn't support IE8 anyway
],
flexbox: 'no-2009',
}),
],
},
},
],
},

@mrchief
Copy link
Collaborator

mrchief commented Aug 10, 2018

I formatted your rules to better understand it and I see a subtle typo

{
    test: /.css$/,
    use: ExtractTextPlugin.extract({
        fallback: 'style-loader',
        use: [{
            loader: 'css-loader'
        }]
    }),
    include: /node_modules[/\]react-dropdown-tree-select/
}, {
    test: /.css$/,
    use: [
        require.resolve('style-loader'),
        {
            loader: require.resolve('css-loader'),
            options: {
                importLoaders: 1,
                modules: true,
                localIdentName: '[Name][local][has:base64:5]'
            },
        },
        {
            loader: require.resolve('postcss-loader'),
            options: {
                // Necessary for external CSS imports to work
                // https://github.com/facebookincubator/create-react-app/issues/2677
                ident: 'postcss',
                plugins: () => [
                    require('postcss-flexbugs-fixes'),
                    autoprefixer({
                        browsers: [
                            '>1%',
                            'last 4 versions',
                            'Firefox ESR',
                            'not ie < 9', // React doesn't support IE8 anyway
                        ],
                        flexbox: 'no-2009',
                    }),
                ],
            },
        },
    ],
},

You're missing an extra slash in include: /node_modules[/\]react-dropdown-tree-select/. Should be include: /node_modules[/\\]react-dropdown-tree-select/ (notice it's [/\\]). In case of regex, that extra slash matters.

The other thing I would ask you to verify is that you're importing your custom css (the one that has material design overrides) somehwere in your code. Nothing else pops out.

If you still have issues, I'd suggest to create a sample repo that reproduces your issue and I can look further.

@xporium
Copy link
Author

xporium commented Aug 10, 2018

hi,
version of webpack : "webpack": "3.8.1"
if i add rule which mentioned in "https://dowjones.github.io/react-dropdown-tree-select/#/story/readme"
than default "react-dropdown-tree-select/dist/styles.css" works proper. But if i add new css file and apply class name than not work.

if i add some other rules like below than this material design work proper but other css mashup.
{
test: /.css$/,
use: ExtractTextPlugin.extract({
fallback: "style-loader",
use: "css-loader"
})
},

please see below css file

body {
margin: 20px;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto,
Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", Helvetica, Arial,
sans-serif;
}

/* fallback, until codesandbox/codesandbox-client#174 is resolved */
@font-face {
font-family: "Material Icons";
font-style: normal;
font-weight: 400;
src: url(https://fonts.gstatic.com/s/materialicons/v36/flUhRq6tzZclQEJ-Vdg-IuiaDsNc.woff2)
format("woff2");
}

.material-icons {
font-family: "Material Icons";
font-weight: normal;
font-style: normal;
font-size: 24px;
line-height: 1;
letter-spacing: normal;
text-transform: none;
display: inline-block;
white-space: nowrap;
word-wrap: normal;
direction: ltr;
font-feature-settings: "liga";
-webkit-font-smoothing: antialiased;
}

/* multiselect is a custom classname to increases the specificity of our styles. It can be anything.

  • The idea is that it is easy to extend/override builtin styles with very little effort.
    */

.multiselect .dropdown-trigger > span:after {
font-size: 12px;
color: #555;
}

.multiselect .toggle {
font: normal normal normal 18px/1 "Material Icons";
color: #555;
white-space: pre;
margin-right: 4px;
}

.multiselect .toggle.collapsed::after {
cursor: pointer;
content: "\E5CF";
vertical-align: middle;
}

.multiselect .toggle.expanded::after {
cursor: pointer;
content: "\E5CE";
vertical-align: middle;
}

/* checkbox styles */
.multiselect .checkbox-item {
position: relative;
width: 1rem;
height: 1rem;
margin-right: 0.75rem;
cursor: pointer;
-webkit-appearance: none;
-moz-appearance: none;
appearance: none;
outline: 0;
vertical-align: middle;
}

.multiselect .checkbox-item:before {
content: "";
position: absolute;
left: 0;
top: 0;
z-index: 1;
width: 100%;
height: 100%;
border: 2px solid #aaa;
transition: all 0.3s ease-in-out;
}

.multiselect .checkbox-item:checked:before {
height: 50%;
-webkit-transform: rotate(-45deg);
transform: rotate(-45deg);
border-top-style: none;
border-right-style: none;
border-color: #2196f3;
}

JS File
import React from 'react';
import './Multiselect.css';
import DropdownTreeSelect from 'react-dropdown-tree-select'
import 'react-dropdown-tree-select/dist/styles.css'

const Multiselect = ( props ) => {
return (

);
};
export default Multiselect;

Now i want also apply "multiselect" css in tree select but for that i have to add rule in webpack and that i dont know my default webpack is below

'use strict';

const autoprefixer = require('autoprefixer');
const path = require('path');
const webpack = require('webpack');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
const InterpolateHtmlPlugin = require('react-dev-utils/InterpolateHtmlPlugin');
const WatchMissingNodeModulesPlugin = require('react-dev-utils/WatchMissingNodeModulesPlugin');
const eslintFormatter = require('react-dev-utils/eslintFormatter');
const ModuleScopePlugin = require('react-dev-utils/ModuleScopePlugin');
const getClientEnvironment = require('./env');
const paths = require('./paths');

// Webpack uses publicPath to determine where the app is being served from.
// In development, we always serve from the root. This makes config easier.
const publicPath = '/';
// publicUrl is just like publicPath, but we will provide it to our app
// as %PUBLIC_URL% in index.html and process.env.PUBLIC_URL in JavaScript.
// Omit trailing slash as %PUBLIC_PATH%/xyz looks better than %PUBLIC_PATH%xyz.
const publicUrl = '';
// Get environment variables to inject into our app.
const env = getClientEnvironment(publicUrl);
const ExtractTextPlugin = require("extract-text-webpack-plugin");
// This is the development configuration.
// It is focused on developer experience and fast rebuilds.
// The production configuration is different and lives in a separate file.
module.exports = {
// You may want 'eval' instead if you prefer to see the compiled output in DevTools.
// See the discussion in facebook/create-react-app#343.
devtool: 'cheap-module-source-map',
// These are the "entry points" to our application.
// This means they will be the "root" imports that are included in JS bundle.
// The first two entry points enable "hot" CSS and auto-refreshes for JS.
entry: [
// We ship a few polyfills by default:
require.resolve('./polyfills'),
// Include an alternative client for WebpackDevServer. A client's job is to
// connect to WebpackDevServer by a socket and get notified about changes.
// When you save a file, the client will either apply hot updates (in case
// of CSS changes), or refresh the page (in case of JS changes). When you
// make a syntax error, this client will display a syntax error overlay.
// Note: instead of the default WebpackDevServer client, we use a custom one
// to bring better experience for Create React App users. You can replace
// the line below with these two lines if you prefer the stock client:
// require.resolve('webpack-dev-server/client') + '?/',
// require.resolve('webpack/hot/dev-server'),
require.resolve('react-dev-utils/webpackHotDevClient'),
// Finally, this is your app's code:
paths.appIndexJs,
// We include the app code last so that if there is a runtime error during
// initialization, it doesn't blow up the WebpackDevServer client, and
// changing JS code would still trigger a refresh.
],
output: {
// Add /* filename */ comments to generated require()s in the output.
pathinfo: true,
// This does not produce a real file. It's just the virtual path that is
// served by WebpackDevServer in development. This is the JS bundle
// containing code from all our entry points, and the Webpack runtime.
filename: 'static/js/bundle.js',
// There are also additional JS chunk files if you use code splitting.
chunkFilename: 'static/js/[name].chunk.js',
// This is the URL that app is served from. We use "/" in development.
publicPath: publicPath,
// Point sourcemap entries to original disk location (format as URL on Windows)
devtoolModuleFilenameTemplate: info =>
path.resolve(info.absoluteResourcePath).replace(/\/g, '/'),
},
resolve: {
// This allows you to set a fallback for where Webpack should look for modules.
// We placed these paths second because we want node_modules to "win"
// if there are any conflicts. This matches Node resolution mechanism.
// facebook/create-react-app#253
modules: ['node_modules', paths.appNodeModules].concat(
// It is guaranteed to exist because we tweak it in env.js
process.env.NODE_PATH.split(path.delimiter).filter(Boolean)
),
// These are the reasonable defaults supported by the Node ecosystem.
// We also include JSX as a common component filename extension to support
// some tools, although we do not recommend using it, see:
// facebook/create-react-app#290
// web extension prefixes have been added for better support
// for React Native Web.
extensions: ['.web.js', '.mjs', '.js', '.json', '.web.jsx', '.jsx'],
alias: {

  // Support React Native Web
  // https://www.smashingmagazine.com/2016/08/a-glimpse-into-the-future-with-react-native-for-web/
  'react-native': 'react-native-web',
},
plugins: [
  // Prevents users from importing files from outside of src/ (or node_modules/).
  // This often causes confusion because we only process files within src/ with babel.
  // To fix this, we prevent you from importing files out of src/ -- if you'd like to,
  // please link the files into your node_modules/ and let module-resolution kick in.
  // Make sure your source files are compiled, as they will not be processed in any way.
  new ModuleScopePlugin(paths.appSrc, [paths.appPackageJson]),
],

},
module: {
strictExportPresence: true,
rules: [
// TODO: Disable require.ensure as it's not a standard language feature.
// We are waiting for https://github.com/facebook/create-react-app/issues/2176.
// { parser: { requireEnsure: false } },

  // First, run the linter.
  // It's important to do this before Babel processes the JS.



  

  {
    test: /\.(js|jsx|mjs)$/,
    enforce: 'pre',
    use: [
      {
        options: {
          formatter: eslintFormatter,
          eslintPath: require.resolve('eslint'),
          
        },
        loader: require.resolve('eslint-loader'),
      },
    ],
    include: paths.appSrc,
  },
  {
    // "oneOf" will traverse all following loaders until one will
    // match the requirements. When no loader matches it will fall
    // back to the "file" loader at the end of the loader list.
    oneOf: [
      // "url" loader works like "file" loader except that it embeds assets
      // smaller than specified limit in bytes as data URLs to avoid requests.
      // A missing `test` is equivalent to a match.
      {
        test: [/\.bmp$/, /\.gif$/, /\.jpe?g$/, /\.png$/],
        loader: require.resolve('url-loader'),
        options: {
          limit: 10000,
          name: 'static/media/[name].[hash:8].[ext]',
        },
      },
      // Process JS with Babel.
      {
        test: /\.(js|jsx|mjs)$/,
        include: paths.appSrc,
        loader: require.resolve('babel-loader'),
        options: {
          
          // This is a feature of `babel-loader` for webpack (not Babel itself).
          // It enables caching results in ./node_modules/.cache/babel-loader/
          // directory for faster rebuilds.
          cacheDirectory: true,
        },
      },
      // {
      //   test: /\.css$/,
      //   include: /node_modules/,
      //   loader: 'style-loader!css-loader!postcss-loader',
       
      //  },
      //  {
      //   test: /\.css$/,
      //   exclude: /node_modules/,
      //   loader: 'style-loader!css-loader?modules&localIdentName=[name]---[local]---[hash:base64:5]!postcss-loader',
      //  },

      //  {
      //   test: /\.css$/,
      //   use: ExtractTextPlugin.extract({
      //     fallback: "style-loader",
      //     use: "css-loader"
      //   })
      // },
      // {
      //   test: /\.css$/,
      //   use: ExtractTextPlugin.extract({
      //     fallback: 'style-loader',
      //     use: [
      //       {
      //         loader: 'css-loader'
      //       }
      //     ]
      //   }),
      //   include: /node_modules[/\\]react-dropdown-tree-select/
      // },
      
      // "postcss" loader applies autoprefixer to our CSS.
      // "css" loader resolves paths in CSS and adds assets as dependencies.
      // "style" loader turns CSS into JS modules that inject <style> tags.
      // In production, we use a plugin to extract that CSS to a file, but
      // in development "style" loader enables hot editing of CSS.
      {
        test: /\.css$/,
        use: [
          require.resolve('style-loader'),
          {
            loader: require.resolve('css-loader'),
            options: {
              importLoaders: 1,
              modules:true,
              localIdentName:'[Name]__[local]__[has:base64:5]'
            },
          },
          {
            loader: require.resolve('postcss-loader'),
            options: {
              // Necessary for external CSS imports to work
              // https://github.com/facebookincubator/create-react-app/issues/2677
              ident: 'postcss',
              plugins: () => [
                require('postcss-flexbugs-fixes'),
                autoprefixer({
                  browsers: [
                    '>1%',
                    'last 4 versions',
                    'Firefox ESR',
                    'not ie < 9', // React doesn't support IE8 anyway
                  ],
                  flexbox: 'no-2009',
                }),
              ],
            },
          },
        ],
      }, 

      // "file" loader makes sure those assets get served by WebpackDevServer.
      // When you `import` an asset, you get its (virtual) filename.
      // In production, they would get copied to the `build` folder.
      // This loader doesn't use a "test" so it will catch all modules
      // that fall through the other loaders.
      {
        // Exclude `js` files to keep "css" loader working as it injects
        // its runtime that would otherwise processed through "file" loader.
        // Also exclude `html` and `json` extensions so they get processed
        // by webpacks internal loaders.
        exclude: [/\.(js|jsx|mjs)$/, /\.html$/, /\.json$/],
        loader: require.resolve('file-loader'),
        options: {
          name: 'static/media/[name].[hash:8].[ext]',
        },
      },
    ],
  },
  // ** STOP ** Are you adding a new loader?
  // Make sure to add the new loader(s) before the "file" loader.
],

},
plugins: [
new ExtractTextPlugin("style.css"),
// Makes some environment variables available in index.html.
// The public URL is available as %PUBLIC_URL% in index.html, e.g.:
//
// In development, this will be an empty string.
new InterpolateHtmlPlugin(env.raw),
// Generates an index.html file with the <script> injected.
new HtmlWebpackPlugin({
inject: true,
template: paths.appHtml,
}),
// Add module names to factory functions so they appear in browser profiler.
new webpack.NamedModulesPlugin(),
// Makes some environment variables available to the JS code, for example:
// if (process.env.NODE_ENV === 'development') { ... }. See ./env.js.
new webpack.DefinePlugin(env.stringified),
// This is necessary to emit hot updates (currently CSS only):
new webpack.HotModuleReplacementPlugin(),
// Watcher doesn't work well if you mistype casing in a path so we use
// a plugin that prints an error when you attempt to do this.
// See https://github.com/facebook/create-react-app/issues/240
new CaseSensitivePathsPlugin(),
// If you require a missing module and then npm install it, you still have
// to restart the development server for Webpack to discover it. This plugin
// makes the discovery automatic so you don't have to restart.
// See https://github.com/facebook/create-react-app/issues/186
new WatchMissingNodeModulesPlugin(paths.appNodeModules),
// Moment.js is an extremely popular library that bundles large locale files
// by default due to how Webpack interprets its code. This is a practical
// solution that requires the user to opt into importing specific locales.
// https://github.com/jmblog/how-to-optimize-momentjs-with-webpack
// You can remove this if you don't use Moment.js:
new webpack.IgnorePlugin(/^./locale$/, /moment$/),
],
// Some libraries import Node modules but don't use them in the browser.
// Tell Webpack to provide empty mocks for them so importing them works.
node: {
dgram: 'empty',
fs: 'empty',
net: 'empty',
tls: 'empty',
child_process: 'empty',
},
// Turn off performance hints during development because we don't do any
// splitting or minification in interest of speed. These warnings become
// cumbersome.
performance: {
hints: false,
},
};

@mrchief
Copy link
Collaborator

mrchief commented Aug 10, 2018

Try importing your css after the dropdown’s css. Or increase the “specificity” of your css selectors.

@xporium
Copy link
Author

xporium commented Aug 13, 2018

hi,
i did (Try importing your css after the dropdown’s css) but still same problem. I think any rule i have to add in webpack config file, but if i used only

// test: /.css$/,
// use: ExtractTextPlugin.extract({
// fallback: "style-loader",
// use: "css-loader"
// })
// },

than default css not work proper

and if i add
// {
// test: /.css$/,
// use: ExtractTextPlugin.extract({
// fallback: 'style-loader',
// use: [
// {
// loader: 'css-loader'
// }
// ]
// }),
// include: /node_modules[/\]react-dropdown-tree-select/
// },

plugins: [
new ExtractTextPlugin("style.css"),
--------
than default work but custom css not work...

@mrchief
Copy link
Collaborator

mrchief commented Aug 13, 2018

Can you create a github repo with all the files/code?

@xporium
Copy link
Author

xporium commented Aug 14, 2018

hi,
sorry actually i cant create github repo for this. but please see below code. but i can provide u specific file. i ran "eject" command for webpack and other configuration.

1)Multiselect.JS

import React from 'react';
import DropdownTreeSelect from 'react-dropdown-tree-select'
import 'react-dropdown-tree-select/dist/styles.css'
import classes from   './Multiselect.css';

const Multiselect = ( props ) => {
    return (        
        <DropdownTreeSelect placeholderText="Search" data={props.data} onChange={props.changed}  className={classes.multiselect}/>        
    );
};
export default Multiselect;
  1. Index.js
let multiselect = null;
        if ( this.props.industrydata  !== null) {
            multiselect = <MultiSelect data={this.props.industrydata} changed={this.onmultiselectchange}/>
        }        
        return (
            <div className={classes.Auth}>
           
                    {multiselect}
                                

            </div>

if add below rule in webpack than default react dropdown tree select css working ok.
But in if i want to add custom css like className={classes.multiselect} than its not working.
So tell me rule that default css and custom css work for "react dropdown tree select"

{
            test: /\.css$/,
            use: ExtractTextPlugin.extract({
              fallback: 'style-loader',
              use: [
                {
                  loader: 'css-loader'
                }
              ]
            }),
            include: /node_modules[/\\]react-dropdown-tree-select/
          },

{
            test: /\.css$/,
            use: [
              require.resolve('style-loader'),
              {
                loader: require.resolve('css-loader'),
                options: {
                  importLoaders: 1,
                  modules:true,
                  localIdentName:'[Name]__[local]__[has:base64:5]'
                },
              },
              {
                loader: require.resolve('postcss-loader'),
                options: {
                  // Necessary for external CSS imports to work
                  // https://github.com/facebookincubator/create-react-app/issues/2677
                  ident: 'postcss',
                  plugins: () => [
                    require('postcss-flexbugs-fixes'),
                    autoprefixer({
                      browsers: [
                        '>1%',
                        'last 4 versions',
                        'Firefox ESR',
                        'not ie < 9', // React doesn't support IE8 anyway
                      ],
                      flexbox: 'no-2009',
                    }),
                  ],
                },
              },
            ],
          }, 

@mrchief
Copy link
Collaborator

mrchief commented Aug 14, 2018

Took the liberty of formatting the code blocks in your post.

Your code looks fine. I don't know what's not working. Simply stating "it's not working" is not very helpful. That's a very vague thing.

Take a look at this branch: https://github.com/dowjones/react-dropdown-tree-select/tree/b7fe7bc77e1a7734bebb36b8de9b8e7aa443f1cc/docs/examples/material

And in your 2nd webpack rule, try excluding node_modules

{
            test: /\.css$/,
            use: ExtractTextPlugin.extract({
              fallback: 'style-loader',
              use: [
                {
                  loader: 'css-loader'
                }
              ]
            }),
            include: /node_modules[/\\]react-dropdown-tree-select/   <--keep this as is
          },

{
            test: /\.css$/,
            exclude: /node_modules/  <-- new condition to exclude css coming from node_modules
            ...

@xporium
Copy link
Author

xporium commented Aug 16, 2018

Hi,

test: /.css$/,
exclude: /node_modules/ <-- new condition to exclude css coming from node_modules
...

that also included in webpack.
my main concern is all working fine without webpack. but if i suppose to run eject command in application so webpack would generated automatically. I had add below rule for default css.

{
test: /.css$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: [
{
loader: 'css-loader'
}
]
}),
include: /node_modules[/\]react-dropdown-tree-select/ <--keep this as is
},

now i want custom css, in that case add one css file and import that file to js file
and than add className={classses.multiselect} its not affect by custom css, its render like default dropdown.

@mrchief
Copy link
Collaborator

mrchief commented Aug 16, 2018

If you don't want to eject, you can still import the default css - but in that case, you need to import it within a JS file (like App.js or component.js). If you eject the app, you have more flexibility as you can setup various css loaders that will allow the import from within css files. It's a matter of coding style. Both approaches are fine.

To keep things simple, try className="multiselect" and let me know.

And instead of import classes from './custom.css', use import './custom.css'

@mrchief
Copy link
Collaborator

mrchief commented Aug 31, 2018

I believe this question has been answered. Happy to reopen this if you find any issues.

@mrchief mrchief closed this as completed Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants