Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set the tabindex on tree select? #339

Closed
pr-arun opened this issue Feb 26, 2020 · 11 comments
Closed

How to set the tabindex on tree select? #339

pr-arun opened this issue Feb 26, 2020 · 11 comments

Comments

@pr-arun
Copy link

pr-arun commented Feb 26, 2020

Is there any property for setting the tabindex on tree select?

@mrchief mrchief changed the title How to set the tabindex on tree select, Is there any property for setting the tabindex on tree select How to set the tabindex on tree select? Feb 26, 2020
@mrchief
Copy link
Collaborator

mrchief commented Feb 26, 2020

Do you mean something like <DropdownSelect tabIndex=n /> and then it reflects the tabIndex on the Input (or something else)?

@pr-arun
Copy link
Author

pr-arun commented Feb 27, 2020

@mrchief Yes.

@mrchief
Copy link
Collaborator

mrchief commented Feb 27, 2020

If it's on the input, I think it's doable. Would you like to send a PR?

@ellinge
Copy link
Collaborator

ellinge commented Feb 27, 2020

I'm guessing it's this value on the trigger/wrapper of the dropdown.
https://github.com/dowjones/react-dropdown-tree-select/blob/develop/src/trigger/index.js#L39

@mrchief
Copy link
Collaborator

mrchief commented Feb 28, 2020

It starts from there but needs to be trickled to the input.

@ellinge
Copy link
Collaborator

ellinge commented Feb 28, 2020

It’s applied to the tabbable trigger/wrapper, a.k.a, the a-tag and not the input.

@mrchief
Copy link
Collaborator

mrchief commented Feb 28, 2020

Right, but does that bring the focus to the input or does it need another tabbing? Further, assigning to 0 is troublesome in a form/page since it may not be the desired index. In other words, I see it as 2 part change:

  • remove the hardcoded 0 and take it as a input prop (defaulting to 0)
  • check to see if we need to trickle it to the input box and whether it's a good idea

@stale
Copy link

stale bot commented Mar 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 14, 2020
@mrchief mrchief added enhancement and removed stale labels Mar 14, 2020
@mrchief
Copy link
Collaborator

mrchief commented Nov 12, 2020

Fixed by #439

@mrchief mrchief closed this as completed Nov 12, 2020
@paycorchauhan
Copy link
Contributor

@mrchief what version will include this change ? Will it be possible to release this since latest 2.5.1 version is missing it.

@mrchief
Copy link
Collaborator

mrchief commented Aug 19, 2021

@paycorchauhan let me check. Will release a new version if that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants