From 101180a83094ab8de6683f595eb4ce26e4ffc1c5 Mon Sep 17 00:00:00 2001
From: Vincent Gao <vincent.gao@dpc.vic.gov.au>
Date: Tue, 18 Apr 2023 17:30:38 +1000
Subject: [PATCH] [SRM-813] Fixes a layout issue for publications

---
 ..._form_display.node.publication.default.yml | 21 ++++++-------
 tide_publication.install                      | 31 +++++++++++++++++++
 2 files changed, 40 insertions(+), 12 deletions(-)

diff --git a/config/install/core.entity_form_display.node.publication.default.yml b/config/install/core.entity_form_display.node.publication.default.yml
index 80237ae..76843c1 100644
--- a/config/install/core.entity_form_display.node.publication.default.yml
+++ b/config/install/core.entity_form_display.node.publication.default.yml
@@ -187,24 +187,21 @@ third_party_settings:
       region: content
       weight: -61
     group_publication_metadata:
-      label: 'Publication metadata'
-      format_type: html_element
-      format_settings:
-        open: true
-        collapsible: false
-        element: div
-        show_label: false
-        label_element: h3
-        label_element_classes: ''
-        required_fields: true
-        attributes: ''
-        classes: 'seven-details js-form-wrapper form-wrapper seven-details__wrapper details-wrapper'
       children:
         - field_license_type
         - field_publication_date
         - field_publication_authors
+      label: ''
       region: content
+      parent_name: ''
       weight: -80
+      format_type: fieldset
+      format_settings:
+        classes: ''
+        show_empty_fields: true
+        id: ''
+        description: ''
+        required_fields: true
 id: node.publication.default
 targetEntityType: node
 bundle: publication
diff --git a/tide_publication.install b/tide_publication.install
index 4344149..4d70f24 100644
--- a/tide_publication.install
+++ b/tide_publication.install
@@ -1025,3 +1025,34 @@ function tide_publication_update_8014() {
     }
   }
 }
+
+/**
+ * Update Publication metadata group to use fieldset.
+ */
+function tide_publication_update_8015() {
+  /** @var \Drupal\Core\Entity\Display\EntityFormDisplayInterface $form_display */
+  $form_display = EntityFormDisplay::load('node.publication.default');
+  $field_group = $form_display->getThirdPartySettings('field_group');
+  $group_settings = [
+    'label' => '',
+    'format_type' => 'fieldset',
+    'format_settings' => [
+      'show_empty_fields' => FALSE,
+      'id' => '',
+      'description' => '',
+      'required_fields' => TRUE,
+      'classes' => '',
+    ],
+    'children' => [
+      'field_license_type',
+      'field_publication_date',
+      'field_publication_authors',
+    ],
+    'region' => 'content',
+    'weight' => -80,
+  ];
+  if (isset($field_group['group_publication_metadata'])) {
+    $form_display->setThirdPartySetting('field_group', 'group_publication_metadata', $group_settings);
+    $form_display->save();
+  }
+}