Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix registries is http generate cert.d file name err #178

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix registries is http generate cert.d file name err #178

merged 2 commits into from
Jul 18, 2023

Conversation

NatureLR
Copy link
Contributor

Description

when containerRuntime.containerd.registries addr is� http then generate cert.d file name err

Related Issue

dragonflyoss/Dragonfly2#2527

@gaius-qi
Copy link
Member

gaius-qi commented Jul 11, 2023 •
edited
Loading

@NatureLR

You should update Chart.yaml version:

  1. https://github.com/dragonflyoss/helm-charts/blob/main/charts/dragonfly/Chart.yaml#L6
  2. https://github.com/dragonflyoss/helm-charts/blob/main/charts/dragonfly/Chart.yaml#L7

Add changelog to Chart.yaml:
https://github.com/dragonflyoss/helm-charts/blob/main/charts/dragonfly/Chart.yaml#L28

@NatureLR
Copy link
Contributor Author

@NatureLR

You should update Chart.yaml version:

  1. https://github.com/dragonflyoss/helm-charts/blob/main/charts/dragonfly/Chart.yaml#L6
  2. https://github.com/dragonflyoss/helm-charts/blob/main/charts/dragonfly/Chart.yaml#L7

Add changelog to Chart.yaml: https://github.com/dragonflyoss/helm-charts/blob/main/charts/dragonfly/Chart.yaml#L28

done

@hyy0322
Copy link
Contributor

hyy0322 commented Jul 11, 2023

@NatureLR DCO is required

@NatureLR
fix registries is http generate cert.d file name err
7af8ea2 
Signed-off-by: NatureLR <1127711564@qq.com>
@NatureLR
update version to 1.0.4
afdbdd9 
Signed-off-by: NatureLR <1127711564@qq.com>
@NatureLR
Copy link
Contributor Author

@NatureLR DCO is required

looks like it's done

gaius-qi
gaius-qi approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 6ba46dc into dragonflyoss:main Jul 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NatureLR @gaius-qi @hyy0322