Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of db-url parameter breaks if # in any field (specifically, password) #2773

Closed
et304383 opened this issue May 23, 2017 · 3 comments
Closed

Comments

@et304383
Copy link

https://github.com/drush-ops/drush/blob/master/includes/sitealias.inc#L1680

Just wasted hours trying to figure this out. Turns out, parse_url doesn't properly handle a URL with a # character contained within.

Drush should handle this since clearly PHP isn't going to fix this.

Tested with Drush 8.1.11 and PHP 5.6

@weitzman
Copy link
Member

weitzman commented Jun 5, 2017

Maybe drush could preprocess the url to escape the #?

@et304383
Copy link
Author

et304383 commented Jun 5, 2017

I suspect '@' and ':' would also need to be handled.

@weitzman
Copy link
Member

dupe of #1134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants