sql-sync should validate aliases

[danepowell]

If you run sql-sync with an invalid alias (i.e. drush sql-sync @foo.remote @foo.local, where @foo.remote isn't a valid alias), you get an obscure error:

PHP Fatal error: Uncaught TypeError: Argument 1 passed to Drush\Commands\sql\SqlSyncCommands::databaseName() must be an instance of Drush\SiteAlias\AliasRecord, boolean given,

This looks like a bug, but in fact is just Drush's way of telling you that you are using an invalid alias.

Ideally sql-sync would validate the provided aliases and provide a more helpful error message, such as if you provide an invalid alias to drush si:

The alias @foo.remote could not be found.

[weitzman]

We do validate aliases -

drush/src/Commands/sql/SqlSyncCommands.php

Line 149 in 53a809e

if (!$sourceRecord = $manager->get($source)) {

. not sure whats going on here.

[greg-1-anderson]

My results:

$ drush9 -s sql-sync @foo.bar @baz.boz
 [error]  Error: no alias record could be found for source @foo.bar 

Are you sure you're using the most up-to-date version of Drush 9?

[danepowell]

We're on beta7 (latest stable), it looks like that validation was only added in the last couple weeks, so it'll be in beta8

[greg-1-anderson]

beta8 has been released now 🎉

[greg-1-anderson]

Reopen if there is a problem.

[danepowell]

Thanks I will try beta8