Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drush.launcher removes spaces from drush.ini settings #3129

Closed
dmp1ce opened this issue Nov 2, 2017 · 4 comments
Closed

drush.launcher removes spaces from drush.ini settings #3129

dmp1ce opened this issue Nov 2, 2017 · 4 comments

Comments

@dmp1ce
Copy link

dmp1ce commented Nov 2, 2017

drush.launcher will remove spaces from values set in drush.ini. This caught me by surprise because I didn't know there were multiple launchers. Now I'm using drush.php which works fine. I was using drush finder which was then calling drush.launcher. Drush is installed via composer using the drupal-composer/drupal-project project using the 7.x branch.

I did spend some time trying to debug the drush.launcher script and found the problem line to be https://github.com/drush-ops/drush/blob/8.x/drush.launcher#L119 although no matter what shell tricks I tried to use, I couldn't figure out how to produce a exec command that would work as expected.

If the code is left as is, then spaces will be removed. For example I had sendmail_path='/usr/bin/msmtp -a myvhost -t' set in drush.ini and it would be changed to sendmail_path='/usr/bin/msmtp-amyvhost-t'. If I left the space in, then the exec command will fail a few lines down in the script.

@greg-1-anderson
Copy link
Member

Drush 7 is no longer supported.

Drush 9 no longer supports drush.ini. It would be best to not rely on it. Try setting the PHPRC environment variable to point to the php.ini you want to use.

@dmp1ce
Copy link
Author

dmp1ce commented Nov 2, 2017

OK. I did get a fix for this. I didn't know that the 8.x branch was Drush 7.

@dmp1ce
Copy link
Author

dmp1ce commented Nov 2, 2017

I'll try to use the PHPRC environment variable.

@greg-1-anderson
Copy link
Member

| I didn't know that the 8.x branch was Drush 7.

The 8.x branch is Drush 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants