Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release dry-auto_inject 0.x version with support for ruby 3.2.1 #89

Open
radarek opened this issue Jun 16, 2023 · 3 comments
Open

Release dry-auto_inject 0.x version with support for ruby 3.2.1 #89

radarek opened this issue Jun 16, 2023 · 3 comments
Labels
bug help wanted

Comments

@radarek
Copy link

radarek commented Jun 16, 2023

This commit 5605781 fixes dry-auto_inject for ruby 3.2.1 It was released as 1.0.1 version. It would be nice to release 0.x version with the same fix so it works with ruby 3.2.1 too. I have a project which can't update dry-auto_inject easily to 1.0.1 (karafka 1.x blocks updating it) and it would help to have 0.x having this fix.

Currently I have to monkey patch PASS_THROUGH array.
@solnic
Copy link
Member

solnic commented Jun 16, 2023

Would you be able to cherry-pick this commit to latest release-0.x branch and open a PR for it? I could release it assuming all tests are green.

@radarek
Copy link
Author

radarek commented Jun 16, 2023

Sure, no problem. Should I bump to 0.9.1 or 0.10.0 version?

@solnic
Copy link
Member

solnic commented Jun 16, 2023

@radarek no, just cherry-pick the commit and open a PR against release-0.9.

@radarek radarek mentioned this issue Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solnic @radarek