Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polynomial fits to residuals #15

Open
dshean opened this issue Apr 19, 2020 · 0 comments
Open

Fix polynomial fits to residuals #15

dshean opened this issue Apr 19, 2020 · 0 comments
Labels

Comments

@dshean
Copy link
Owner

dshean commented Apr 19, 2020

The initial dem_align.py planar fit to remove post-co-registration residuals worked well. The current n-order polynomial fit functionality is largely untested. User reports in Dec 2019 indicated this functionality is not working correctly, something that I was able to reproduce with quick tests, but didn't have the time to document and fix.

Change from geolib.ma_fitplane to geolib.ma_fitpoly:

vals, resid, coeff = geolib.ma_fitpoly(diff_align_filt, order=polyorder, gt=gt, perc=(0,100), origmask=False)

This pygeotools/geolib commit updated underlying fitting routines to support arbitrary higher-order polynomials:
dshean/pygeotools@fbd7b97#diff-0c9ae3a15902d51d1f8374a5976f4d79

Notes suggest we should consider numpy.polynomial.polynomial here. I need to revisit local branches - I thought I started this, but did not merge in master.

May be an issue of when/how the resulting "tiltcorr" correction is applied. I wanted another iteration of the main Nuth and Kaab optimization after the residual correction was removed, as it's possible that the final translation would be different after removing systematic residuals.

Should also rename command line option from -tiltcorr to -remove_residuals or something along those lines.

@dshean dshean added the bug label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant