Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming "descending" parameter in PercentileRankOneFeature #869

Closed
shaycrk opened this issue Nov 5, 2021 · 1 comment
Closed

Renaming "descending" parameter in PercentileRankOneFeature #869

shaycrk opened this issue Nov 5, 2021 · 1 comment
Assignees
@shaycrk

Comments

@shaycrk
Copy link
Contributor

shaycrk commented Nov 5, 2021

The behavior of the descending parameter in PercentileRankOneFeature is actually a bit confusing and might be more clear if renamed something along the lines of descending_with_higher_scores or high_scores_larger_values (wordy, but more clear)
@shaycrk shaycrk self-assigned this Nov 5, 2021
@shaycrk shaycrk linked a pull request Nov 12, 2021 that will close this issue
Renaming PercentileRankOneFeature descend parameter (closes #869) #870
Closed
@shaycrk shaycrk mentioned this issue Dec 7, 2021
Merged
@shaycrk
Copy link
Contributor Author

shaycrk commented Dec 7, 2021

Closed via #871

@shaycrk shaycrk closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaycrk shaycrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming PercentileRankOneFeature descend parameter (closes #869) dssg/triage
1 participant
@shaycrk