Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define kD/TPR-Tree data associators for existing associators #472

Closed
sdhiscocks opened this issue Jul 27, 2021 · 1 comment
Closed

Define kD/TPR-Tree data associators for existing associators #472

sdhiscocks opened this issue Jul 27, 2021 · 1 comment
Assignees
Labels
enhancement good first issue A good first issue to start contributing to the project

Comments

@sdhiscocks
Copy link
Member

sdhiscocks commented Jul 27, 2021

The tree mixins are useful to enable using the tree structures on different, but current data associators require definition with mixins every time you want to use them. I think we could just include them in the stonesoup.dataassocaitor.tree.

Definitions are already present in tests:

class DetectionKDTreeNN(DetectionKDTreeMixIn, NearestNeighbour):
"""DetectionKDTreeNN from NearestNeighbour and DetectionKDTreeMixIn"""
pass
class DetectionKDTreeGNN(DetectionKDTreeMixIn, GlobalNearestNeighbour):
"""DetectionKDTreeGNN from GlobalNearestNeighbour and DetectionKDTreeMixIn"""
pass
class DetectionKDTreeGNN2D(DetectionKDTreeMixIn, GNNWith2DAssignment):
"""DetectionKDTreeGNN2D from GNNWith2DAssignment and DetectionKDTreeMixIn"""
pass
class TPRTreeNN(TPRTreeMixIn, NearestNeighbour):
"""TPRTreeNN from NearestNeighbour and TPRTreeMixIn"""
pass
class TPRTreeGNN(TPRTreeMixIn, GlobalNearestNeighbour):
"""TPRTreeGNN from GlobalNearestNeighbour and TPRTreeMixIn"""
pass
class TPRTreeGNN2D(TPRTreeMixIn, GNNWith2DAssignment):
"""TPRTreeGNN2D from GNNWith2DAssignment and TPRTreeMixIn"""
pass
class KDTreePDA(DetectionKDTreeMixIn, PDA):
pass
class KDTreeJPDA(DetectionKDTreeMixIn, JPDA):
pass
class TPRTreePDA(TPRTreeMixIn, PDA):
pass
class TPRTreeJPDA(TPRTreeMixIn, JPDA):
pass

@sdhiscocks sdhiscocks added enhancement good first issue A good first issue to start contributing to the project labels Jul 27, 2021
@sdhiscocks
Copy link
Member Author

Resolved with #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue A good first issue to start contributing to the project
Projects
None yet
Development

No branches or pull requests

2 participants