Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing log level tests after switching to rust-toolchain #85

Closed
drager opened this issue Jun 8, 2023 · 2 comments
Closed

Failing log level tests after switching to rust-toolchain #85

drager opened this issue Jun 8, 2023 · 2 comments

Comments

@drager
Copy link

drager commented Jun 8, 2023

Hello, we recently switched to dtolnay/rust-toolchain from actions-rs/toolchain@v1 in wasm-pack and now some of our tests are failing (running fine locally with the same rust version).

The failures are available here:
https://github.com/rustwasm/wasm-pack/actions/runs/5145936487/jobs/9264280002
failures:
log_level::log_level_error
log_level::log_level_info
log_level::log_level_warn

The test code: https://github.com/rustwasm/wasm-pack/blob/6af9f2275003759d2a746c1f2533af8e30bbee64/tests/all/log_level.rs#L43-L94

Do you know anything about this and possibly how we can solve this? Feels a bit weird that our tests are failing after switching and are only doing so in CI and that's mainly why I'm opening this issue here.

Thanks!

@dtolnay
Copy link
Owner

dtolnay commented Jun 8, 2023

rustwasm/wasm-pack#1294

@dtolnay dtolnay closed this as completed Jun 8, 2023
@drager
Copy link
Author

drager commented Jun 8, 2023

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants