Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support projects without setup.cfg #228

Closed
duckinator opened this issue Dec 15, 2020 · 4 comments · Fixed by #314
Closed

Support projects without setup.cfg #228

duckinator opened this issue Dec 15, 2020 · 4 comments · Fixed by #314
Milestone

Comments

@duckinator
Copy link
Owner

It seems like setup.cfg is used exclusively for the project name. Providing a way to specify it in pyproject.toml might be useful, for folks not using setuptools (or who are doing a quick migration and still use setup.py).

I explicitly do not want to try to process setup.py. It can't be done without running it.

@duckinator
Copy link
Owner Author

This also appears specific to ZipApps.

@nbraud
Copy link
Collaborator

nbraud commented Apr 11, 2021

Given that people are supposed to have a pyproject.toml when using bork, I think it would indeed make sense to support configuring bork through that file.

If we do that, I think it would be a good idea to deprecate configuring bork through setup.cfg. Since that's more-or-less a breaking change, we might want to add a warning in bork v6, and stop looking at setup.cfg in bork v7 (or maybe even assert there's no bork-related config in there)

@duckinator
Copy link
Owner Author

duckinator commented Apr 18, 2021

@nbraud the value from setup.cfg that is used is metadata.name. e.g., from https://github.com/duckinator/bork/blob/main/setup.cfg:

[metadata]
name = bork

That's the only place it's used. Given that it's always there with setup.cfg-based setuptools configurations, and would be redundant to put in both, I'm wondering about checking pyproject.toml and falling back to setup.cfg?

@duckinator duckinator modified the milestone: v6.1.0 Mar 29, 2022
@duckinator duckinator added this to the v7.0.0 milestone Apr 12, 2023
@duckinator
Copy link
Owner Author

duckinator commented May 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants