Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Instructions up to date? #114

Open
layeddie opened this issue Feb 27, 2023 · 5 comments
Open

Are Instructions up to date? #114

layeddie opened this issue Feb 27, 2023 · 5 comments
Assignees
Labels
chore a tedious but necessary task often paying technical debt good first issue Good for newcomers help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished starter A beginner-friendly issue that is a good starting point for a new person T2h Time Estimate 2 Hours

Comments

@layeddie
Copy link

Having some problems following the instructions
elixir -v
Erlang/OTP 25 [erts-13.0] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit]

Elixir 1.14.3 (compiled with Erlang/OTP 25)

mix phx.new -v
Phoenix installer v1.7.0

First error - section 2
Create the lib/liveview_chat_web/views/message_view.ex file: creates this error but file contents pasted from instructions.

mix phx.server
Compiling 1 file (.ex)

== Compilation error in file lib/liveview_chat_web/views/message_view.ex ==
** (UndefinedFunctionError) function LiveviewChatWeb.view/0 is undefined or private
LiveviewChatWeb.view()
expanding macro: LiveviewChatWeb.using/1
lib/liveview_chat_web/views/message_view.ex:2: LiveviewChatWeb.MessageView (module)
(elixir 1.14.3) expanding macro: Kernel.use/2
lib/liveview_chat_web/views/message_view.ex:2: LiveviewChatWeb.MessageView (module)

Delete files paragraph is asking to delete default generated code folders and files that do not exist.
Finally you can delete all the default generated code linked to the PageController:

rm test/liveview_chat_web/controllers/page_controller_test.exs
rm lib/liveview_chat_web/controllers/page_controller.ex
rm test/liveview_chat_web/views/page_view_test.exs
rm lib/liveview_chat_web/views/page_view.ex
rm -r lib/liveview_chat_web/templates/page
@nelsonic
Copy link
Member

Hi @layeddie indeed. this one of the tutorials that we haven't updated yet. ⏳

{:phoenix, "~> 1.6.0"},

If you need a Phoenix 1.7 Tutorial, consider: https://github.com/dwyl/phoenix-chat-example

@layeddie
Copy link
Author

Hi @layeddie indeed. this one of the tutorials that we haven't updated yet. ⏳

{:phoenix, "~> 1.6.0"},

If you need a Phoenix 1.7 Tutorial, consider: https://github.com/dwyl/phoenix-chat-example

Thankyou - it wasnt me going mad then.

@nelsonic nelsonic added good first issue Good for newcomers help wanted If you can help make progress with this issue, please comment! T2h Time Estimate 2 Hours starter A beginner-friendly issue that is a good starting point for a new person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished chore a tedious but necessary task often paying technical debt labels Feb 27, 2023
@nelsonic
Copy link
Member

Todo

  • Go through the tutorial and update to latest Phoenix + LiveView and
  • Update the README.md accordingly
  • Ensure that the deployment to Fly.io is working
  • Wipe the DB so that we can clear the noise:
image
  • Seed some real-looking chat into the Fly.io app to set the tone.

@nelsonic
Copy link
Member

@SimonLab given that you've done the most work on this repo I wanted to give you the chance to make the updates. 👌

@chargio
Copy link

chargio commented Aug 17, 2023

I have started working on an updated version of the tutorial. Would that be ok?

  •  Using context instead of a plain schema for the messages, keeping the boundary in its context.
  • Updating to use Tailwind with a two columns set (one for messages, one for presence)
  • Delete views as they are no longer used
  • Create components for messages

The changes are significant, so review will be hard. Let me know if you are ok with that. I will create a version in its own repo so you can decide if it is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt good first issue Good for newcomers help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished starter A beginner-friendly issue that is a good starting point for a new person T2h Time Estimate 2 Hours
Projects
Status: 🔖 Ready for Development
Development

No branches or pull requests

4 participants