-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily notification to ask users to label their trips #703
Comments
Hi @lgharib : the code is not in the main e-mission-phone app, |
@PatGendre that code is for trip-end notifications. Our testers found the trip-end notifications too bothersome. @lgharib
|
Once you confirm that this works, would be great if you could update the instructions.
|
@shankari thanks for the explanation :-) |
@PatGendre the second cron actually builds the tour model for the users from the already completed trips. The step that infers and completes the uncompleted labels is run as part of the intake pipeline. |
@shankari thanks for the explanation. |
@PatGendre each trip now has two inferences:
We use the tour model to generate the second. |
Closing this since the original question has been answered |
Hi @shankari I am trying to implement push notification with Ma Mobilité using Firbase. We replaced the google-service.js and GoogleService-Info.plist by the one we created on Firebase. I did a build and published it to test on my Samsung Galaxy S10. From the Firebase console I tried to send a message to both Apps but didn't receive any notification. On another hand I wanted to send a message to specific device from the console test tool but I couldn't find the FCM device token in the profiles in the e-mission server database. Apparently the device_tokens are supposed to be pushed to the server from the phone on splash screen intialisation. I noticed that the PushNotify.startupInit(); was commented (so is the 'emission.splash.pushnotify' module reference) in www/js/controllers.js. I decided to remove the comment on it but I received the following message: After investigating the master branch of e-mission-phone I noticed that you no longer use |
@lgharib when did you last pull from the e-mission-phone master? I changed to havesource 5 months ago (e-mission/e-mission-phone@6ebeb28), and merged that change into master in December (e-mission/e-mission-phone#804). I made a bunch of other upgrades at the same time, so I would suggest:
Couple of other things to check:
|
That is because, in order to make the modules self-contained, the push notifications are now initialized from within the module. In the |
@lgharib were you able to figure this out? |
HI @shankari thank you for your answer. I am still troubleshooting. I have pulled the latest version of master. Also I noticed the overwrite with the fake configutaion so I commented the script in https://github.com/e-mission/e-mission-phone/blob/master/setup/setup_shared_native.sh#L7 to make sur that the configuration in platform/android and platform/ios is correct. I think my issue is more with phonegap-plugin-push and not being replaced correctly. |
@lgharib did you remove the plugin and re-add it? Just changing it in the config.xml doesn't do anything on cordova. doesn't even do it for |
@shankari thank you for your advice it was probably related to the cache. I was able to build a version that sends the device_token correctly to the server. I have now two device_tokens and tested sending push notifications using the script and Firebase online console but still not notifications on my phone. ./e-mission-py.bash bin/push/push_to_users.py -t "Trip labels requested" "Please label your trips for the day" -a WARNING:root:ignoring entry {'curr_platform': 'android'} due to None values |
What do the phone logs show? Hard to debug without any logs. Make sure that your phone screen is locked and the app is not opened - if it is opened, the notification is received directly by the app instead of showing up on the screen. |
Ok I think that's why the app was opened |
Closing this issue since it appears to be resolved. |
Where is the daily scheduled mechanism notification system to invite users to label there trips located?
The text was updated successfully, but these errors were encountered: