From 3726a4d71014998762f550798b8f668f4bb3cd89 Mon Sep 17 00:00:00 2001 From: Ravi Nagarjun Akella Date: Mon, 9 Sep 2024 10:13:16 -0700 Subject: [PATCH] shutdown raft services before grpc server --- conanfile.py | 2 +- src/lib/messaging.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/conanfile.py b/conanfile.py index 6b9fe75..738a9c4 100644 --- a/conanfile.py +++ b/conanfile.py @@ -3,7 +3,7 @@ class NuRaftGrpcConan(ConanFile): name = "nuraft_grpc" - version = "6.1.1" + version = "6.1.2" homepage = "https://github.com/eBay/nuraft_mesg" description = "A gRPC service for NuRAFT" topics = ("ebay", "nublox", "raft") diff --git a/src/lib/messaging.cpp b/src/lib/messaging.cpp index 67b1fe1..923793d 100644 --- a/src/lib/messaging.cpp +++ b/src/lib/messaging.cpp @@ -53,8 +53,10 @@ service::service() = default; service::~service() { if (_mesg_service) { - _grpc_server->shutdown(); + // IMPORTANT: The order matters. nuraft can be using the grpc server that might crash the system if grpc server + // is shutdown first. _mesg_service->shutdown(); + _grpc_server->shutdown(); } }