Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-disable FFTW quad precision on RISC-V #3314

Merged

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Apr 24, 2024

I ran into this error when compiling FFTW on RISC-V:

checking for sinq in -lquadmath... no
configure: error: quad precision requires libquadmath for quad-precision trigonometric routines

It's already disabled for Arm and POWER, this PR also disables it for RISC-V.

@bedroge
Copy link
Contributor Author

bedroge commented Apr 24, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="FFTW-3.3.10-GCC-12.3.0.eb FFTW-3.3.10-GCC-13.2.0.eb FFTW-3.3.10-iimpi-2022a.eb FFTW-3.3.10-iimpi-2022b.eb"

@boegelbot
Copy link

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3314 EB_ARGS="FFTW-3.3.10-GCC-12.3.0.eb FFTW-3.3.10-GCC-13.2.0.eb FFTW-3.3.10-iimpi-2022a.eb FFTW-3.3.10-iimpi-2022b.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3314 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4030

Test results coming soon (I hope)...

- notification for comment with ID 2074908200 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Contributor Author

bedroge commented Apr 24, 2024

Test report by @bedroge

Overview of tested easyconfigs (in order)

  • SUCCESS FFTW-3.3.10-GCC-13.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
starfive - Linux Debian GNU/Linux n/a, RISC-V-64, UNKNOWN, Python 3.10.9
See https://gist.github.com/bedroge/e817a080e73244154749f69ac1d70586 for a full test report.

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS FFTW-3.3.10-GCC-12.3.0.eb
  • SUCCESS FFTW-3.3.10-GCC-13.2.0.eb
  • SUCCESS FFTW-3.3.10-iimpi-2022a.eb
  • SUCCESS FFTW-3.3.10-iimpi-2022b.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/65f2548ed26e9fd94bc2d2b66b87edce for a full test report.

@SebastianAchilles SebastianAchilles added this to the release after 4.9.1 milestone Apr 26, 2024
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS FFTW-3.3.10-GCC-12.3.0.eb
  • SUCCESS FFTW-3.3.10-GCC-13.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
arriesgado-5 - Linux Ubuntu 22.04, RISC-V-64, UNKNOWN (u74mc), Python 3.10.12
See https://gist.github.com/SebastianAchilles/5fac95a8fd50eaad90da3383136ef64c for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @bedroge!

@SebastianAchilles SebastianAchilles merged commit 6210331 into easybuilders:develop Apr 26, 2024
47 checks passed
@bedroge bedroge deleted the riscv_disable_quad_prec branch April 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EESSI Related to EESSI project enhancement riscv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants