Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip leading local/ from pylibdir where appropriate #3464

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Sep 26, 2024

Without this, when trying to use EB to install EasyBuild as a module, I get the following error:

== 2024-09-26 13:59:47,138 pythonpackage.py:283 INFO Active Python installation scheme: posix_local
== 2024-09-26 13:59:47,140 pythonpackage.py:302 INFO Found 'local' subdirectory in installation prefix /home/userfs/c/csrv944/.local/easybuild/software/EasyBuild/4.9.4: ['local']
== 2024-09-26 13:59:47,141 pythonpackage.py:305 INFO Subdirectories of /home/userfs/c/csrv944/.local/easybuild/software/EasyBuild/4.9.4/local: ['local', 'lib', 'contrib', 'easybuild', 'etc', 'bin']
== 2024-09-26 13:59:47,404 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/tools/build_log.py:111 in caller_info): Failed to install EasyBuild packages: [Errno 22] Invalid argument: '/home/userfs/c/csrv944/.local/easybuild/software/EasyBuild/4.9.4/local' (at easybuild/easyblocks/e/easybuildmeta.py:158 in install_step)

the [Errno 22] Invalid argument is due to trying to symlink <installdir>/local/local -> <installdir>/local which obviously won't work

@jfgrimm jfgrimm added this to the release after 4.9.4 milestone Sep 26, 2024
@jfgrimm
Copy link
Member Author

jfgrimm commented Sep 26, 2024

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.9.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
slbclpc027 - Linux Ubuntu 24.04, x86_64, Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz, Python 3.12.3
See https://gist.github.com/jfgrimm/b6a341a42ac8bb01012f51d888f552cf for a full test report.

@jfgrimm
Copy link
Member Author

jfgrimm commented Sep 26, 2024

edit: report that showcases the permissions issue with read-only-installdir enabled (see easybuilders/easybuild-framework#4658)

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • FAIL (build issue) EasyBuild-4.9.4.eb

Build succeeded for 0 out of 1 (1 easyconfigs in total)
slbclpc027 - Linux Ubuntu 24.04, x86_64, Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz, Python 3.12.3
See https://gist.github.com/jfgrimm/6ceb9180ad3b951c5f49911b2899ee96 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 26, 2024

@boegelbot please test @ generoso
EB_ARGS="EasyBuild-4.9.4.eb"

@boegel
Copy link
Member

boegel commented Sep 26, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS matplotlib-3.9.2-gfbf-2024a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3105.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/05a33bc5369dc94ed4ab39419c1ea19c for a full test report.

@boegelbot
Copy link

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3464 EB_ARGS="EasyBuild-4.9.4.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3464 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14349

Test results coming soon (I hope)...

- notification for comment with ID 2377733130 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.9.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/9a1634cbf568b887390daeb04ad5ac1b for a full test report.

@boegel boegel changed the title strip leading local/ from pylibdir where appropriate strip leading local/ from pylibdir where appropriate Sep 26, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 26, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="matplotlib-3.9.2-gfbf-2024a.eb"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3464 EB_ARGS="matplotlib-3.9.2-gfbf-2024a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3464 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4948

Test results coming soon (I hope)...

- notification for comment with ID 2377798797 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS matplotlib-3.9.2-gfbf-2024a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/263fb2b395cc2202cce3ab22be66f55b for a full test report.

@boegel boegel merged commit aff313d into easybuilders:develop Sep 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants