Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{compiler}[GCCcore/13.3.0] AOCC v4.2.0 #21343

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

maxim-masterov
Copy link
Collaborator

@maxim-masterov maxim-masterov commented Sep 6, 2024

(created using eb --new-pr)

Depends on easyblock PR easybuilders/easybuild-easyblocks#3437

@Thyre
Copy link
Contributor

Thyre commented Sep 6, 2024

There's an issue for the AOCC EasyBlock in regards to the Clang version. Here, we switch to just using 16 as the Clang version so that the sanity check passes.

I would rather keep the exact version and instead update the EasyBlock. The changes are straightforward and can mostly be copied from the Clang EasyBlock.

easybuilders/easybuild-easyblocks#3429

@SebastianAchilles SebastianAchilles added the 2024a issues & PRs related to 2024a common toolchains label Sep 6, 2024
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 6, 2024
@maxim-masterov
Copy link
Collaborator Author

@Thyre Makes sense, I've created a PR for the AOCC easyblock and updated the version of Clang in this easyconfig.

@Thyre
Copy link
Contributor

Thyre commented Sep 23, 2024

With changed EasyBlock

Test report by @Thyre
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3458
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 560.35.03, Python 3.12.6
See https://gist.github.com/Thyre/1250e9aa6274af284c0c82332852ce1f for a full test report.

@Thyre
Copy link
Contributor

Thyre commented Sep 23, 2024

Without changed EasyBlock

Test report by @Thyre
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 560.35.03, Python 3.12.6
See https://gist.github.com/Thyre/957032cfb123d50a4200d5ea2ad7254b for a full test report.

@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21343 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21343 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4942

Test results coming soon (I hope)...

- notification for comment with ID 2376321805 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Sep 26, 2024

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/94caf9d4f11d61898c5ab7d17997cf3f for a full test report.

Failed because:

ERROR EasyBuild crashed with an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): Failed to write to /project/def-maintainers/boegelbot/sources/a/AOCC/aocc-compiler-4.2.0.tar: [Errno 104] Connection reset by peer

@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21343 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21343 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4943

Test results coming soon (I hope)...

- notification for comment with ID 2376362888 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/a5135d5dca1f85b8911d5a35faa0aa7d for a full test report.

@Thyre
Copy link
Contributor

Thyre commented Sep 26, 2024

Test report by @boegelbot FAILED Build succeeded for 0 out of 1 (1 easyconfigs in total) jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/a5135d5dca1f85b8911d5a35faa0aa7d for a full test report.

That's weird. I tried downloading the sources manually and the SHA256 matched.

 jreuter@ZAM054  ~  wget https://download.amd.com/developer/eula/aocc/aocc-4-2/aocc-compiler-4.2.0.tar
--2024-09-26 12:39:52--  https://download.amd.com/developer/eula/aocc/aocc-4-2/aocc-compiler-4.2.0.tar
Resolving download.amd.com (download.amd.com)... 23.37.35.150
Connecting to download.amd.com (download.amd.com)|23.37.35.150|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 142189580 (136M) [application/x-tar]
Saving to: ‘aocc-compiler-4.2.0.tar’

aocc-compiler-4.2.0.tar                 100%[=============================================================================>] 135,60M  10,2MB/s    in 13s     

2024-09-26 12:40:06 (10,4 MB/s) - ‘aocc-compiler-4.2.0.tar’ saved [142189580/142189580]

 jreuter@ZAM054  ~  sha256sum aocc-compiler-4.2.0.tar
ed5a560ec745b24dc0685ccdcbde914843fb2f2dfbfce1ba592de4ffbce1ccab  aocc-compiler-4.2.0.tar

@branfosj
Copy link
Member

@boegelbot please test @ jsc-zen3
EB_ARGS="--force-download"

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21343 EB_ARGS="--force-download" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21343 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4944

Test results coming soon (I hope)...

- notification for comment with ID 2376596976 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1e543b73b8cd44ac1ddef539e9ac5187 for a full test report.

@branfosj
Copy link
Member

Test report by @boegelbot FAILED Build succeeded for 0 out of 1 (1 easyconfigs in total) jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/a5135d5dca1f85b8911d5a35faa0aa7d for a full test report.

That's weird. I tried downloading the sources manually and the SHA256 matched.

The first failure will have left a partial download. The second failure detected this partial download and failed as it has the wrong checksum. The --force-download makes EasyBuild redownload the file and works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024a issues & PRs related to 2024a common toolchains update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants