-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workload names containing a dot fail when calling ank apply #341
Comments
Hi, We cannot allow "." in workload names, as we use it as separator in the filter-, field- and update-mask and also in the workload instance name. What we should do now is to introduce a new data structure |
Thanks for the clarification! Enforcing it would make sense as Ankaios and the ank CLI should treat YAML files exactly the same. |
@windsource proposed to also restrict the length of the names. We could also make a suggestion in the documentation for a separator, i.e.: "_", "-" |
I am currently working on this. |
As we are already adding some constraints on the workload names here, we can also limit the length of the names to avoid problems later. To get an initial impression, we can start here by finding out what the limits of other possible runtimes are, e.g., docker, crun, containerd, system processes (native workloads), northstar, or how other orchestrators handle this. |
Workload names containing a dot work in the Ankaios init state file. But when calling
ank apply file.yml
, the ank CLI crashes.Current Behavior
ank --insecure apply test.yml
With backtrace:
RUST_BACKTRACE=full ank --insecure apply test.yml
Expected Behavior
The workload is applied.
Steps to Reproduce
Create the test.yml file:
Then call
ank --insecure apply test.yml
Context (Environment)
EWAOL, arm64, AWS EC2 t4g.large
systemd 250 (250.5+)
podman version 4.3.1-dev
Ankaios 0.3.1 and 0.4.0 (earlier versions not tested)
Logs
see above.
Additional Information
In the init state file read by the Ankaios server on startup, dots in workload names do work.
Final result
To be filled by the one closing the issue.
The text was updated successfully, but these errors were encountered: