Regression in cditck-porting tests with GlassFish 6 Full Platform (nightly build as of September 14, 2020)) #23205
Labels
ee9-tck
issues related to Jakarta EE 9 TCK failures
Comments
|
Weird as there has been nothing related to schema changed in GlassFish over the week. |
|
@smillidge still, last weeks build passed but yesterdays (nightly build) didn't. Should we build Glassfish 6.0 using one of the commits that were merged between Sept 14-Sept 6 and run the cditck-porting tests against that (web accessible) GlassFish build? In case it helps, I am pasting some server.log schema exceptions here: |
|
Which was "last weeks'" build? |
|
@gurunrao we should run again with https://download.eclipse.org/ee4j/cdi/3.0/cdi-tck-3.0.1-dist.zip to verify that the same failures occur. @smillidge I will add a link to the passing CDI TCK run with "last weeks" build. |
|
From the logs I see Therefore I suspect this is related to the JPA schema changes and we need to wait for an updated EclipseLink |
|
Does anybody know the details of the schema change for JPA. Maybe we need to package a new schema? |
|
More digging it look like we are missing some schemas from https://jakarta.ee/xml/ns/jakartaee/#9 here https://github.com/eclipse-ee4j/glassfish/tree/master/appserver/deployment/schemas/src/main/resources/glassfish/lib/schemas. I will add the missing schemas |
|
@smillidge eclipse-ee4j/eclipselink#886 should reference the EclipseLink issue related to updating to Jakarta EE 9 schema. There is also a JPA-DEV ML conversation https://www.eclipse.org/lists/jpa-dev/msg00073.html that mentions the EclipseLink updates are not yet complete. |
Thanks @gurunrao for running https://ci.eclipse.org/jakartaee-tck/job/cditck-porting/job/master/94 with https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/enterprise/cdi-tck-dist/3.0.1/cdi-tck-dist-3.0.1-dist.zip The same test failures are reproducing still. I downloaded both https://download.eclipse.org/ee4j/cdi/3.0/cdi-tck-3.0.1-dist.zip + https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/enterprise/cdi-tck-dist/3.0.1/cdi-tck-dist-3.0.1-dist.zip, unzipped them and did |
Thanks @smillidge ^ sounds encouraging! |
|
@scottmarlow Neither of those sums match what I see on the cdi project download: Scotts-iMacPro:2.0 starksm$ sha256sum /tmp/cdi-tck-3.0.1-dist.zip
f0a3bdd81ea552ddf2c2a6cd2576f0d5ca45026665cb4a5c42606a58bf1c133d /tmp/cdi-tck-3.0.1-dist.zipwhich matches what is in the metdata file in the download area: f0a3bdd81ea552ddf2c2a6cd2576f0d5ca45026665cb4a5c42606a58bf1c133d target/cdi-tck-3.0.1-dist.zip
-rw-r--r-- 1 jenkins 1001010000 8680202 Aug 30 19:03 target/cdi-tck-3.0.1-dist.zipI do agree with the https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/enterprise/cdi-tck-dist/3.0.1/cdi-tck-dist-3.0.1-dist.zip sum: which I don't understand how it differs. I'll look into whether there are two version staged and one needs to be dropped. |
|
@starksm64 thanks for checking, I had deleted the leading |
@smillidge I noticed that you closed this issue, could you please confirm that the missing schemas are merged in now? |
|
@scottmarlow not yet. I will open another issue for that. As the last TCK passed I decided to close this as the tests are now passing. |
@smillidge the https://ci.eclipse.org/jakartaee-tck/job/cditck-porting/job/master/96/#showFailuresLink still shows test failures. |
|
OK missed that I was looking at the CTS Full profile results. |
|
#23237 brings in all the latest schemas |
|
@scottmarlow @smillidge |
|
No idea why I will have to do some debugging into what is going on. Can you point me to some instructions on how to run the tests locally? |
|
@smillidge - #23149 (comment) link has steps to build/run the CDI porting kit tests as documented by Scott. |
|
https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/resources/org/jboss/cdi/tck/tests/implementation/simple/resource/persistenceContext/persistence.xml in the CDI TCK has not been updated to the new schema |
|
Not sure if that will fix it but I raised jakartaee/cdi-tck#216 |
|
@gurunrao sorry for the confusion about CDI releases but https://download.eclipse.org/jakartaee/cdi/3.0/cdi-tck-3.0.1-dist.zip is what we should test with. I had asked for https://download.eclipse.org/jakartaee/cdi/3.0/cdi-tck-3.0.2-dist.zip but we didn't actually need it. jakartaee/specifications#242 shows (http://download.eclipse.org/jakartaee/cdi/3.0/cdi-tck-3.0.1-dist.zip) |
|
@scottmarlow - We get same failures with http://download.eclipse.org/jakartaee/cdi/3.0/cdi-tck-3.0.1-dist.zip , CI link here https://ci.eclipse.org/jakartaee-tck/job/cditck-porting/job/master/98/ |
|
Anyone know how to run just a failing test? |
|
Adding debug the requested schema is http://java.sun.com/xml/ns/persistence/persistence_2_0.xsd |
|
I have added the missing persistence_2_0.xsd to the GlassFish schemas and tested and passed the cditck-porting tests locally. However although this will pass the tests I don't think the TCK should be trying to deploy something with a persistence 2.0 schema. I haven't found where the schema reference is coming from as Arquillian is creating the deployment in the TCKs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #23184 (comment), the cditck-porting tests show 14 test failures.
The failures only are recreating with the latest (September 14, 2020) nightly build. Last weeks https://download.eclipse.org/ee4j/glassfish/weekly/glassfish-6.0.0-SNAPSHOT-2020-09-06.zip build still passes the cditck-porting tests.
The text was updated successfully, but these errors were encountered: