Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonBinding will close writer #647

Open
lazyrobert opened this issue Aug 19, 2024 · 0 comments
Open

JsonBinding will close writer #647

lazyrobert opened this issue Aug 19, 2024 · 0 comments
Labels
bug Something isn't working right

Comments

@lazyrobert
Copy link

Describe the bug
@OverRide
public void toJson(Object object, Type type, Writer writer) throws JsonbException {
final SerializationContextImpl marshaller = new SerializationContextImpl(jsonbContext, type);
try (JsonGenerator generator = writerGenerator(writer)) {
marshaller.marshallWithoutClose(object, generator);
}
}

try with resource will auto invoke JsonGenerator.close, and close the writer, so marshallWithoutClose has no effect

To Reproduce
Steps to reproduce the bug

Expected behavior
A clear and concise description of what you expected to happen.

System information:

  • OS: Windows
  • Java Version: 17
  • Yasson Version: 3.0.4

Additional context
Add any other context about the problem here.

@lazyrobert lazyrobert added the bug Something isn't working right label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

1 participant