From e97a4e0754a4123649146f88c66495045db04083 Mon Sep 17 00:00:00 2001 From: Nitin <45592624+nitin-vavdiya@users.noreply.github.com> Date: Fri, 1 Sep 2023 15:33:48 +0530 Subject: [PATCH 1/3] default enforceHttpsInDidWebResolution set to true It should be default true as in production we can not trust unsecured connections. --- charts/managed-identity-wallet/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/managed-identity-wallet/values.yaml b/charts/managed-identity-wallet/values.yaml index 2124e5a60..cb65cd23a 100644 --- a/charts/managed-identity-wallet/values.yaml +++ b/charts/managed-identity-wallet/values.yaml @@ -119,7 +119,7 @@ miw: environment: "dev" ssi: # -- Enable to use HTTPS in DID Web Resolution - enforceHttpsInDidWebResolution: false + enforceHttpsInDidWebResolution: true # -- Verifiable Credential expiry date. Format 'dd-MM-yyyy'. If empty it is set to 31-12- vcExpiryDate: "" authorityWallet: From 4f821ad0c3cdd87e091e48732d3ee1d947262f3a Mon Sep 17 00:00:00 2001 From: Nitin <45592624+nitin-vavdiya@users.noreply.github.com> Date: Fri, 1 Sep 2023 15:40:19 +0530 Subject: [PATCH 2/3] Update deployment_test.yaml --- .../tests/custom-values/deployment_test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/managed-identity-wallet/tests/custom-values/deployment_test.yaml b/charts/managed-identity-wallet/tests/custom-values/deployment_test.yaml index 37c546f76..d1e3398b4 100644 --- a/charts/managed-identity-wallet/tests/custom-values/deployment_test.yaml +++ b/charts/managed-identity-wallet/tests/custom-values/deployment_test.yaml @@ -60,7 +60,7 @@ tests: - name: AUTHORITY_WALLET_DID value: did:web:RELEASE-NAME-managed-identity-wallet%3A8080:BPNL000000000000 - name: ENFORCE_HTTPS_IN_DID_RESOLUTION - value: "false" + value: "true" - name: APPLICATION_ENVIRONMENT value: dev - name: KEYCLOAK_REALM From f4090c8ca286c4173fdf1e53857a9223c16529f7 Mon Sep 17 00:00:00 2001 From: Nitin <45592624+nitin-vavdiya@users.noreply.github.com> Date: Fri, 1 Sep 2023 15:41:13 +0530 Subject: [PATCH 3/3] Update deployment_test.yaml --- .../managed-identity-wallet/tests/default/deployment_test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/managed-identity-wallet/tests/default/deployment_test.yaml b/charts/managed-identity-wallet/tests/default/deployment_test.yaml index 0a8a1458b..1578632fa 100644 --- a/charts/managed-identity-wallet/tests/default/deployment_test.yaml +++ b/charts/managed-identity-wallet/tests/default/deployment_test.yaml @@ -119,7 +119,7 @@ tests: - name: AUTHORITY_WALLET_DID value: did:web:RELEASE-NAME-managed-identity-wallet%3A8080:BPNL000000000000 - name: ENFORCE_HTTPS_IN_DID_RESOLUTION - value: "false" + value: "true" - name: APPLICATION_ENVIRONMENT value: dev - name: KEYCLOAK_REALM