Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRG new: Docker file notice #360

Closed
Siegfriedk opened this issue Nov 16, 2023 · 4 comments · Fixed by eclipse-tractusx/eclipse-tractusx.github.io#629
Closed

TRG new: Docker file notice #360

Siegfriedk opened this issue Nov 16, 2023 · 4 comments · Fixed by eclipse-tractusx/eclipse-tractusx.github.io#629
Assignees

Comments

@Siegfriedk
Copy link
Contributor

In our TRG Walkthrough we discussed to add a new TRG which only contains the information regarding Dockerfile notice file.

AC:

  • Create new TRG in Documentation which says that the Dockerfile needs its own README.md/Notice file which then needs to be used when uploading an image to dockerhub
@SebastianBezold
Copy link
Contributor

Hi @Siegfriedk,

I cannot remember the discussions we had on that topic.
We already have a dedicated "Notice for Docker image" TRG here: https://eclipse-tractusx.github.io/docs/release/trg-4/trg-4-06

Is this about mandating, that the notice has to be a separate file? Or should I improve the description, so it becomes clearer, that there are these two options?

@Siegfriedk
Copy link
Contributor Author

@SebastianBezold mhhh no clue. Im pretty sure we want to enforce a notice file for the docker image only and that it has to be uploaded to docker hub. If it fits in 4.06, thats probably fine

@SebastianBezold
Copy link
Contributor

Ah ok, so if we want to enforce the standalone file, then I'll update the description slightly. Right now both cases, README.md section and standalone file, are valid

@SebastianBezold
Copy link
Contributor

I opted to first ask for feedback on the potential change on our mailing list.
If positive, i'll update the TRG description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants