Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variables #88

Open
1 task
timgrossmann opened this issue Aug 2, 2019 · 2 comments
Open
1 task

Fix environment variables #88

timgrossmann opened this issue Aug 2, 2019 · 2 comments

Comments

@timgrossmann
Copy link
Contributor

timgrossmann commented Aug 2, 2019 •
edited
Loading

Since the React frontend is sent to the calling client browser, the environment variables of the server don't have any effect.

  • Change the way the environment variables are set in order to allow for configurable elements on the server side
@timgrossmann
Copy link
Contributor Author

By prefixing the env variables with REACT_APP they will be imported into the application.

@timgrossmann timgrossmann reopened this Aug 2, 2019
@timgrossmann
Copy link
Contributor Author

Since the PORT env var is set by the system, the port for the device retrieval has to be aligned, however this means dynamically setting the REACT_APP_PORT on runtime which might lead to problems.
This has to be further researched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timgrossmann