Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ecCodes function to determine if descriptor is coordinate #62

Open
iainrussell opened this issue Jun 30, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@iainrussell
Copy link
Member

What maintenance does this project need?

eccodes-python 1.6.0 will introduce a new function, codes_bufr_key_is_coordinate(msgid, key) (https://jira.ecmwf.int/browse/ECC-1611) which pdbufr should use to replace its own code. Let's wait until that version of eccodes-python has been released for a bit before making it a dependency.

Organisation

ECMWF

@iainrussell iainrussell added the enhancement New feature or request label Jun 30, 2023
@sandorkertesz
Copy link
Collaborator

Please note that codes_bufr_key_is_coordinate uses a different algorithm than pdbufr to decide if a key is a coordinate and for certain keys they disagree. This should also taken into account before making this change.

@shahramn
Copy link

shahramn commented Jun 30, 2023

See https://confluence.ecmwf.int/display/UDOC/What+are+coordinate+descriptors+-+ecCodes+BUFR+FAQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants