Skip to content

Commit

Permalink
[bug-OpenMage#302] CURLOPT_SSLVERSION is hard-coded in Mage_HTTP_Clie…
Browse files Browse the repository at this point in the history
…nt_Curl

./mage list-upgrades
Error:
list-upgrades: TCP connection reset by peer

remove specific ssl version, first because version specified TLS v1 is not supported by connect20.magentocommerce.com
https://www.ssllabs.com/ssltest/analyze.html?d=connect20.magentocommerce.com&s=52.3.167.65

and second because server can choise right version byself
tested on centos
PHP 5.5.38 (cli) (built: Feb 18 2017 08:04:56)
curl 7.54.1 (x86_64-redhat-linux-gnu) libcurl/7.54.1 NSS/3.28.4 zlib/1.2.7 libpsl/0.7.0 (+libicu/50.1.2) libssh2/1.8.0 nghttp2/1.21.1
  • Loading branch information
empiricompany authored and edannenberg committed Dec 6, 2017
1 parent 02625ae commit 533647e
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions downloader/lib/Mage/HTTP/Client/Curl.php
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,7 @@ protected function makeRequest($method, $uri, $params = array(), $isAuthorizatio
$this->_ch = curl_init();
$this->curlOption(CURLOPT_URL, $uriModified);
$this->curlOption(CURLOPT_SSL_VERIFYPEER, true);
/**
* Use value from CURL_SSLVERSION_TLSv1 (available since PHP 5.5)
*
* @link http://php.net/manual/ru/function.curl-setopt.php
*/

$this->curlOption(CURLOPT_SSLVERSION, 1);

$this->getCurlMethodSettings($method, $params, $isAuthorizationRequired);

if(count($this->_headers)) {
Expand Down

0 comments on commit 533647e

Please sign in to comment.