Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/show UI elements based on permissions #120

Open
Mr0grog opened this issue Sep 15, 2017 · 5 comments
Open

Hide/show UI elements based on permissions #120

Mr0grog opened this issue Sep 15, 2017 · 5 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Sep 15, 2017

This depends on actually having permissions implemented in the API (edgi-govdata-archiving/web-monitoring-db#34), so we can’t quite do this work yet.

Once the API returns permission information for a user, we should use that to limit/modify what we display:

  • A user might have all their basic view permissions revoked, in which case we should not request any data at all and display a message.

  • A user may not have permission to view annotations, in which case we should hide the annotation form/view (kind of like we do now when not logged in, but we should change the message)

  • A user may have permission to view annotations, but not make new ones, so we should have a view-only/disabled version of the annotation form.

@Mr0grog Mr0grog added this to the V0 milestone Sep 15, 2017
@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Jan 10, 2019

Still a thing that has to happen.

@stale stale bot removed the stale label Jan 10, 2019
@stale
Copy link

stale bot commented Jul 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2019
@stale stale bot removed the stale label Jul 9, 2019
@lightandluck
Copy link
Collaborator

Added never-stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants