Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Action on Save Check is broken in RLS Mode #283

Open
CryZe opened this issue Jun 20, 2017 · 4 comments
Open

Action on Save Check is broken in RLS Mode #283

CryZe opened this issue Jun 20, 2017 · 4 comments

Comments

@CryZe
Copy link
Contributor

CryZe commented Jun 20, 2017

In RLS Mode it opens a new terminal every time you save and executes cargo check there. You need to close the terminal every single time, otherwise it just creates more and more terminals. This is completely different from what it does in Legacy Mode where it just does all this in the background without opening new terminals.

@KalitaAlexey
Copy link
Member

It's not broken.
It's how it supposed to work, but I agree it looks weird.
How would you like it to work?

@CryZe
Copy link
Contributor Author

CryZe commented Jun 20, 2017

Can it maybe reuse the same terminal or something? It's kinda weird that I have hundreds of terminals open after saving a hundred times. Also can there be an option to have the legacy behavior instead? I don't even want it to open a terminal at all if possible.

@KalitaAlexey
Copy link
Member

@CryZe,
There is an issue about allowing use Legacy Mode.
Also some people want to parse diagnostics from running Cargo commands even for RLS mode.
Actually it shouldn't create many terminals. It either removes the current one and creates a new one or ignores the command.
I believe it worked. Doesn't it work now?

@BeeWarloc
Copy link

BeeWarloc commented Jul 19, 2017

I have the same problem in latest released version (0.4.2), both on Windows and on macOS; a new terminal session is opened, and kept open, every time cargo check has run. I'm also using RLS mode, but RLS still seems a bit unstable so I tend to run cargo check too.

I have version 1.14.1 version of VS code installed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants