Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid accidentally changing remote-config and ansible vars in same PR #789

Open
4 tasks
timmc-edx opened this issue Sep 4, 2024 · 0 comments
Open
4 tasks

Comments

@timmc-edx
Copy link
Member

timmc-edx commented Sep 4, 2024

Add a CI check in edx-internal and edge-internal to keep people from accidentally changing remote-config and Ansible vars in the same PR, since this has caused a number of production incidents in the past.

Acceptance criteria:

  • A PR that tries to change both directories gets a failing CI check
  • The check is marked as required (blocking merge when it fails)
  • Workflow logs a helpful error message explaining the reasoning
    • Optional: Present the error message as a comment using gh cli
  • Optional: If it's really simple, allow bypassing the restriction via a special label. (This is a little tricky because you'd need a way to rerun the check if the label is added afterwards. Maybe not automated, but require devs to ask GH to re-run the check?)
@timmc-edx timmc-edx changed the title CI check to prevent people from accidentally changing remote-config and ansible vars in same PR Avoid accidentally changing remote-config and ansible vars in same PR Sep 4, 2024
@timmc-edx timmc-edx assigned timmc-edx and unassigned timmc-edx Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Development
Development

No branches or pull requests

1 participant