Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar has scrollbars for headings with code fomatting #100

Closed
jkloosterman opened this issue Jan 5, 2021 · 3 comments · Fixed by #101
Closed

Sidebar has scrollbars for headings with code fomatting #100

jkloosterman opened this issue Jan 5, 2021 · 3 comments · Fixed by #101
Labels
bug Something isn't working

Comments

@jkloosterman
Copy link

jkloosterman commented Jan 5, 2021

Describe the bug
If there are headings that include code formatting, those headings are shown with individual vertical scrollbars in the sidebar

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://eecs485staff.github.io/p2-insta485-serverside/
  2. Observe that there are scrollbars in the sidebar

Expected behavior
There are no scrollbars for individual headings in the sidebar.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Chrome
  • Version 87.0.4280.88
@jkloosterman jkloosterman added the bug Something isn't working label Jan 5, 2021
@awdeorio
Copy link
Contributor

awdeorio commented Jan 5, 2021

I think this is expected behavior. At least, that's what I had in mind when I made those headings. If you think there's a more clear way to present the spec and/or sidebar in that project let me know. I think this is EECS 485 P2.

@jkloosterman
Copy link
Author

jkloosterman commented Jan 5, 2021

I'm referring to the tiny vertical scrollbars for each item, like "/accounts/logout/". The scrollbar only scrolls a pixel or two.

@seshrs
Copy link
Member

seshrs commented Jan 6, 2021

Thanks for reporting @jkloosterman! The vertical scrollbars definitely look jarring... I think the fix could be to simply never show vertical scrollbars. (It's probably okay if content gets cut vertically, I expect this would only happen if using extra tall characters like those in some non-Latin scripts.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants