Spooky icons even when Spooky theme not chosen

[eecs441staff]

Describe the bug
I'm seeing the Spooky theme icons for theme selection and the hamburger menu even when I haven't selected the Spooky theme.

To Reproduce
They just showed up.

Expected behavior
Normal icons shown when Spooky theme not chosen.

Screenshots

Desktop (please complete the following information):

• macOS Ventura 13.0
• Safari
• 16.1

[seshrs]

Oops! These were only meant to show up around Halloween 😬

I’ll push a fix right away. Thanks for informing me about this!

[seshrs]

Fixed in e858180, and I've release v1.8.2 with the fixes. Again, thanks so much for reporting!

---

Aside:
You can expect the Halloween icons to appear as an Easter egg for a limited time from October 25 to November 5.

primer-spec/src_js/conditional_plugins/should_load_plugin.ts

Lines 30 to 33 in c400fba

	return isTodayInRange(
	{ month: Month.OCTOBER, date: 25 },
	{ month: Month.NOVEMBER, date: 5 },
	);

If you don't want Easter eggs to be displayed on your website, then update your _config.yml to set disableJokes to true.