Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch version v4.10.2 has breaking changes #358

Closed
cristiano-belloni opened this issue Nov 8, 2022 · 3 comments
Closed

Patch version v4.10.2 has breaking changes #358

cristiano-belloni opened this issue Nov 8, 2022 · 3 comments

Comments

@cristiano-belloni
Copy link

Hi, the latest version of rollup-plugin-esbuild contains this change: https://github.com/egoist/rollup-plugin-esbuild/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L56, which changes the supported engines in a non-backwards-compatible way. This is a breaking change, and it's currently breaking all projects that use this plugin (or have dependencies that use this plugin) that are incompatible with rollup-plugin-esbuild's engines range (without doing anything, just a clean npm install).

Would it be possible to revert this change in a new patch version, deprecate the version that contains this change and finally publish a major version with the new engines in order to respect semver?

Many thanks,
Cristiano.

@egoist
Copy link
Owner

egoist commented Nov 8, 2022

you're right, it should be a major version upgrade.

@egoist
Copy link
Owner

egoist commented Nov 8, 2022

4.10.3 and 5.0.0 have been released to fix this.

@egoist egoist closed this as completed Nov 8, 2022
@cristiano-belloni
Copy link
Author

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants