From 74206620acb1b8a7ad17291b6e28b39d883beb69 Mon Sep 17 00:00:00 2001 From: saiprakash-v Date: Thu, 22 Dec 2022 17:11:59 +0530 Subject: [PATCH 1/2] Removing hardcoded facility country code --- .env.example | 3 ++- backend/certificate_api/configs/config.js | 4 +++- backend/certificate_api/src/services/certificate_service.js | 2 +- docker-compose.yml | 1 + 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.env.example b/.env.example index 17e3a230e..e889589d6 100644 --- a/.env.example +++ b/.env.example @@ -53,4 +53,5 @@ MOSIP_IDA_CERT_KEY="-----BEGIN CERTIFICATE-----\nMIIFcDCCA1gCCQDImfyNShfG0DANBgk MOSIP_MISP_LICENSE_KEY=fyNShfG0DANBgkqhkiG9w0BAQsFADB6MQswCQYDVQQGEwJJT MOSIP_PARTNER_ID=divoc MOSIP_PARTNER_API_KEY=123456 -NOTIFY_TOPIC='notify' \ No newline at end of file +NOTIFY_TOPIC='notify' +FACILITY_COUNTRY_CODE='IN' \ No newline at end of file diff --git a/backend/certificate_api/configs/config.js b/backend/certificate_api/configs/config.js index 66f733c9e..528c69702 100644 --- a/backend/certificate_api/configs/config.js +++ b/backend/certificate_api/configs/config.js @@ -17,6 +17,7 @@ const ETCD_AUTH_ENABLED = process.env.ETCD_AUTH_ENABLED === "true" const ETCD_USERNAME = process.env.ETCD_USERNAME; const ETCD_PASSWORD = process.env.ETCD_PASSWORD; const ENTITY_TYPES = process.env.ENTITY_TYPES; +const FACILITY_COUNTRY_CODE = process.env.FACILITY_COUNTRY_CODE || ''; module.exports = { REGISTRY_URL, JWT_PUBLIC_KEY, @@ -36,5 +37,6 @@ module.exports = { ETCD_AUTH_ENABLED, ETCD_USERNAME, ETCD_PASSWORD, - ENTITY_TYPES + ENTITY_TYPES, + FACILITY_COUNTRY_CODE }; \ No newline at end of file diff --git a/backend/certificate_api/src/services/certificate_service.js b/backend/certificate_api/src/services/certificate_service.js index 7138f8562..b5bc1d120 100644 --- a/backend/certificate_api/src/services/certificate_service.js +++ b/backend/certificate_api/src/services/certificate_service.js @@ -312,7 +312,7 @@ const convertCertificateToDCCPayload = async(certificateRaw, nameDetails) => { } function getAlpha2CodeForCountry(addressCountry) { - return getAlpha2CodeFromAlpha3(addressCountry) || getAlpha2CodeFromName(addressCountry) || getAlpha2CodeIfValid(addressCountry) || 'IN'; + return getAlpha2CodeFromAlpha3(addressCountry) || getAlpha2CodeFromName(addressCountry) || getAlpha2CodeIfValid(addressCountry) || config.FACILITY_COUNTRY_CODE; } function getAlpha2CodeFromAlpha3(addressCountry) { diff --git a/docker-compose.yml b/docker-compose.yml index 74ecf44be..179457d55 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -341,6 +341,7 @@ services: CONFIGURATION_LAYER: "etcd" ETCD_USERNAME: $ETCD_USERNAME ETCD_PASSWORD: $ETCD_PASSWORD + FACILITY_COUNTRY_CODE: $FACILITY_COUNTRY_CODE depends_on: kafka: condition: service_healthy From bd23124bdd540e2433434068748f0f487fee70b2 Mon Sep 17 00:00:00 2001 From: saiprakash-v Date: Thu, 22 Dec 2022 17:40:06 +0530 Subject: [PATCH 2/2] fixing tests --- backend/certificate_api/tests/certificate_service.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/backend/certificate_api/tests/certificate_service.test.js b/backend/certificate_api/tests/certificate_service.test.js index 1f24b9a5b..6f8bb2061 100644 --- a/backend/certificate_api/tests/certificate_service.test.js +++ b/backend/certificate_api/tests/certificate_service.test.js @@ -5,6 +5,7 @@ const config = require('../configs/config'); const constants = require('../configs/constants'); config.DISEASE_CODE = 'COVID-19'; config.PUBLIC_HEALTH_AUTHORITY = 'Govt Of India'; +config.FACILITY_COUNTRY_CODE='IN'; config.ETCD_URL = 'etcd:2379' var mockConstructor = { getObject: jest.fn().mockImplementation((args) => {