Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling extension and monolog leads to unexpected errors when no extension #242

Open
PWalkow opened this issue Nov 29, 2019 · 1 comment

Comments

@PWalkow
Copy link

PWalkow commented Nov 29, 2019

As in #221 , enabling both monolog and extension leads to MissingExtensionException in NewRelicHandler on a LoggerInterface call.

Minimum configuration:

### ekino_new_relic.yaml
ekino_new_relic:
    enabled: true
    exceptions: true
    deprecations: true
    monolog:
        enabled: true
        level: error

should there be an extra check before loading the monolog handler even if it is not supported by missing extension to avoid playing with the configuration for environments that does not have an extension?

@thiagorb
Copy link

Another problem with the current approach is that you can't disable the bundle via environment variables, cause the check for New Relic extension happens while the bundle is being loaded, and at this moment the environment variables are not resolved yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants