Skip to content

Commit

Permalink
[Agent] Enable monitoring by default (#18204)
Browse files Browse the repository at this point in the history
This enables monitoring of the agent by default. This PR only changes it in the configuration file. If we decide to move forward with this default, it should also be changed in the code.

The reason I think monitoring should be enabled out of the box as it will make debugging agents easier as all the data is directly avaiable in Elasticsearch and enhances the out of the box experience.
  • Loading branch information
ruflin committed May 5, 2020
1 parent 25a813e commit 22c944d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
16 changes: 8 additions & 8 deletions x-pack/elastic-agent/_meta/config/common.p2.yml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ datasources:
- metricset: filesystem
dataset: system.filesystem

settings.monitoring:
# enabled turns on monitoring of running processes
enabled: true
# enables log monitoring
logs: true
# enables metrics monitoring
metrics: true

# management:
# # Mode of management, the Elastic Agent support two modes of operation:
# #
Expand Down Expand Up @@ -112,14 +120,6 @@ datasources:
# # Default is false
# exponential: false

# settings.monitoring:
# # enabled turns on monitoring of running processes
# enabled: false
# # enables log monitoring
# logs: false
# # enables metrics monitoring
# metrics: false

# Sets log level. The default log level is info.
# Available log levels are: error, warning, info, debug
#logging.level: trace
16 changes: 8 additions & 8 deletions x-pack/elastic-agent/elastic-agent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ datasources:
- metricset: filesystem
dataset: system.filesystem

settings.monitoring:
# enabled turns on monitoring of running processes
enabled: true
# enables log monitoring
logs: true
# enables metrics monitoring
metrics: true

# management:
# # Mode of management, the Elastic Agent support two modes of operation:
# #
Expand Down Expand Up @@ -118,14 +126,6 @@ datasources:
# # Default is false
# exponential: false

# settings.monitoring:
# # enabled turns on monitoring of running processes
# enabled: false
# # enables log monitoring
# logs: false
# # enables metrics monitoring
# metrics: false

# Sets log level. The default log level is info.
# Available log levels are: error, warning, info, debug
#logging.level: trace
Expand Down

0 comments on commit 22c944d

Please sign in to comment.