Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Check dedot for tags/labels in GCP #15904

Closed
kaiyan-sheng opened this issue Jan 28, 2020 · 2 comments
Closed

[Metricbeat] Check dedot for tags/labels in GCP #15904

kaiyan-sheng opened this issue Jan 28, 2020 · 2 comments
Assignees
@kaiyan-sheng
Labels
Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team

Comments

@kaiyan-sheng
Copy link
Contributor

Similar to #15843 for AWS, if dot . is allowed for tags in GCP, then we might run into the same issue. For example: tag key might be app.kubernetes.io/name. We should have dedot as default for tags.
@kaiyan-sheng kaiyan-sheng added Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team labels Jan 28, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jan 28, 2020
@kaiyan-sheng
Copy link
Contributor Author

For labels in GCP, Only hyphens (-), underscores (_), lowercase characters, and numbers are allowed. Keys must start with a lowercase character. International characters are allowed. Therefore, dedotting is not needed for GCP.

@kaiyan-sheng
Copy link
Contributor Author

For VM name in GCP: name must be lowercase letters, numbers, and hyphens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaiyan-sheng