Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic-agent][container] increase limit for retries to Kibana #25063

Closed
simitt opened this issue Apr 14, 2021 · 7 comments
Closed

[elastic-agent][container] increase limit for retries to Kibana #25063

simitt opened this issue Apr 14, 2021 · 7 comments
Assignees
Labels
Team:Elastic-Agent Label for the Agent team v7.13.0

Comments

@simitt
Copy link
Contributor

simitt commented Apr 14, 2021

The container cmd retries requests to Kibana up to 30 times with 1 second sleep intervals.
Kibana can take several minutes to start up. Increase the retry counter/timeout accordingly, or make it configurable. This is important for scenarios where Kibana and the Elastic Agent get deployed at the same time, such as in ESS/ECE.

@simitt simitt added v7.13.0 Team:Elastic-Agent Label for the Agent team labels Apr 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@ph
Copy link
Contributor

ph commented Apr 14, 2021

@michalpristas Can you take a look at this one?
@simitt I would consider this a bug, but the risk is to have a disconnected instance of Elastic Agent, right?

And should we make it retry infinitely?

@blakerouse
Copy link
Contributor

We should not make it go infinitely by default. It would be better to see the container restarted in Kubernetes versus it always up even though its not connected.

I think adding ENV variables to control this would be best.

@simitt
Copy link
Contributor Author

simitt commented Apr 14, 2021

making the timeout configurable SGTM;

but the risk is to have a disconnected instance of Elastic Agent, right?

yes, but in some cases that's preferable to having the container being restarted (because the elastic-agent is in beta, but apm-server also started from this process is GA).

@ph
Copy link
Contributor

ph commented Apr 14, 2021

Ok, let's make it configurable.

@ph
Copy link
Contributor

ph commented Apr 20, 2021

@simitt The retry PR were merged, let's confirm and close this issue?

@ruflin
Copy link
Member

ruflin commented Apr 21, 2021

Closing, please reopen if issue still exists.

@ruflin ruflin closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team v7.13.0
Projects
None yet
Development

No branches or pull requests

6 participants