Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Composed Verifier does not always remove files #30280

Closed
blakerouse opened this issue Feb 8, 2022 · 1 comment · Fixed by #30281
Closed

[Elastic Agent] Composed Verifier does not always remove files #30280

blakerouse opened this issue Feb 8, 2022 · 1 comment · Fixed by #30281
Assignees
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@blakerouse
Copy link
Contributor

Elastic Agent uses the composed.Verifier to chain multiple verifiers together. The issue in this code is that only the last verify is allowed to remove the files when it fails. If the previous verifiers in the chain fail then they do not remove the files.

The code needs to be changed to ensure that at any point that a verifier fails that the files are removed (when enabled), instead of waiting for the last verifier (which might not be reached).

@blakerouse blakerouse added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 8, 2022
@blakerouse blakerouse self-assigned this Feb 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23 jlind23 changed the title [Elastic Agent] Combosed Verifier does not always remove files [Elastic Agent] Composed Verifier does not always remove files Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants