Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Filebeat haproxy.log to ECS even more! #10143

Merged
merged 9 commits into from
Jan 17, 2019
Merged

Convert Filebeat haproxy.log to ECS even more! #10143

merged 9 commits into from
Jan 17, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Jan 17, 2019 •
edited
Loading

This module was migrated prior to ECS 1.0.0-beta2, and therefore has a few things left to migrate.

Caveats

  • haproxy.bytes_read: Both the TCP logs and the HTTP logs use the field. So it's copied to http.response.bytes when parsing HTTP logs, but not when parsing TCP logs.

Renames

  • haproxy.http.response.status_code => http.response.status_code

Different scale, original fields still present:

  • haproxy.http.request.time_active_ms => event.duration
  • haproxy.tcp.processing_time_ms => event.duration

Note that haproxy.client.ip is migrated in #10141

TODO

  • Alias renamed fields to their ECS counterpart, not forgetting migration: true
  • Document field migrations in ecs-migration.yml
  • Changelog

@webmat webmat requested review from a team as code owners January 17, 2019 05:06
@webmat webmat self-assigned this Jan 17, 2019
@webmat webmat added in progress Pull request is currently in progress. module Filebeat Filebeat ecs labels Jan 17, 2019
@webmat webmat force-pushed the ecs-haproxy-fb-part2 branch 2 times, most recently from 2ead1e3 to b12abe2 Compare January 17, 2019 05:13
ruflin
ruflin approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the follow up cleanup.

filebeat/module/haproxy/log/test/httplog-no-headers.log-expected.json Show resolved Hide resolved
filebeat/module/haproxy/log/test/tcplog.log Show resolved Hide resolved
@webmat webmat changed the title WIP Convert Filebeat haproxy.log to ECS even more! Convert Filebeat haproxy.log to ECS even more! Jan 17, 2019
@webmat webmat mentioned this pull request Jan 17, 2019
Merged
@webmat
Copy link
Contributor Author

webmat commented Jan 17, 2019

Spotted one detail prior to merging. Will merge when CI is green.

@webmat webmat merged commit 74076cc into elastic:master Jan 17, 2019
@webmat webmat deleted the ecs-haproxy-fb-part2 branch January 17, 2019 21:45
@webmat
Copy link
Contributor Author

webmat commented Jan 17, 2019

CI test failures unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@webmat webmat

Labels
ecs Filebeat Filebeat in progress Pull request is currently in progress. module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmat @ruflin