Remove experimental log message when xpack.enabled flag is set #10222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
module
review
needs_backport
|
Pinging @elastic/stack-monitoring |
ycombinator
force-pushed
the
mb-stack-xp-flag
branch
2 times, most recently
from
3e76033
to
89f00e2
Compare
ruflin
approved these changes
Jan 22, 2019
ycombinator
force-pushed
the
mb-stack-xp-flag
branch
from
89f00e2
to
7d11734
Compare
|
@ruflin it looks like the Windows jobs in Jenkins were aborted. I'm guessing this is intentional? If so, given that the other jobs were successful and Travis is green, are you good with me merging this PR? |
cachedout
approved these changes
Jan 22, 2019
|
@ruflin Yes, I'm good to go. I aborted the windows build as they couldn't keep up and stalled our builds. |
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Jan 23, 2019
This was referenced Jan 24, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Elasticsearch and Kibana Metricbeat modules support an
xpack.enabledflag. This flag's value defaults tofalse, causing these modules to index their data intometricbeat-*indices, as is normal with all other Metricbeat modules.However, we want to use these modules for Stack Monitoring as well. Concretely, this means that these modules' data would need to be indexed into
.monitoring-*indices instead ofmetricbeat-*indices. This change of indexing target is enabled by settingxpack.enabled: true.Until this PR, setting
xpack.enabled: trueand the code path that it enabled was marked as experimental. Log messages in the Metricbeat logs would inform the users as such.This PR removes these log messages and thus makes the use of this flag as GA. It also documents this flag in the modules' configuration yaml files.