Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Enable System module config on Windows #10237

Merged
merged 3 commits into from
Jan 28, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Jan 22, 2019

This should have actually been part of #9954 or even previous PRs.

The host and process datasets are implemented for Windows, and the docs now say so, but unfortunately I missed that the config we ship for Windows has the whole system module disabled. It can still be configured manually, of course, but with this change it will show up in the reference files as well.

@cwurm cwurm added bug review needs_backport PR is waiting to be backported to other branches. Auditbeat SecOps labels Jan 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@cwurm cwurm requested a review from a team as a code owner January 22, 2019 09:17
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than point outlined by Andrew, this LGTM

@cwurm
Copy link
Contributor Author

cwurm commented Jan 25, 2019

I've excluded socket.state.period and user.state.period on Windows. @andrewkroh Let me know if it looks good now.

@cwurm cwurm merged commit e8013bd into elastic:master Jan 28, 2019
@cwurm cwurm deleted the system_config_enable_windows branch January 28, 2019 11:14
cwurm pushed a commit to cwurm/beats that referenced this pull request Jan 28, 2019
Bugfix: Include System module in configuration files on Windows.
(cherry picked from commit e8013bd)
@cwurm cwurm added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 28, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Jan 28, 2019
Bugfix: Include System module in configuration files on Windows.
(cherry picked from commit e8013bd)
cwurm pushed a commit that referenced this pull request Jan 30, 2019
… Windows (#10362)

Bugfix: Include System module in configuration files on Windows.

(cherry picked from commit e8013bd)
cwurm pushed a commit that referenced this pull request Jan 30, 2019
Bugfix: Include System module in configuration files on Windows.

(cherry picked from commit e8013bd)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…nfig on Windows (elastic#10362)

Bugfix: Include System module in configuration files on Windows.

(cherry picked from commit fdd4245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants