-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auditbeat] Enable System module config on Windows #10237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwurm
added
bug
review
needs_backport
PR is waiting to be backported to other branches.
Auditbeat
SecOps
labels
Jan 22, 2019
Pinging @elastic/secops |
andrewkroh
reviewed
Jan 23, 2019
webmat
reviewed
Jan 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than point outlined by Andrew, this LGTM
I've excluded |
webmat
approved these changes
Jan 25, 2019
andrewkroh
approved these changes
Jan 27, 2019
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Jan 28, 2019
Bugfix: Include System module in configuration files on Windows. (cherry picked from commit e8013bd)
cwurm
added
v6.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Jan 28, 2019
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Jan 28, 2019
Bugfix: Include System module in configuration files on Windows. (cherry picked from commit e8013bd)
cwurm
pushed a commit
that referenced
this pull request
Jan 30, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…nfig on Windows (elastic#10362) Bugfix: Include System module in configuration files on Windows. (cherry picked from commit fdd4245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have actually been part of #9954 or even previous PRs.
The
host
andprocess
datasets are implemented for Windows, and the docs now say so, but unfortunately I missed that the config we ship for Windows has the whole system module disabled. It can still be configured manually, of course, but with this change it will show up in the reference files as well.