[Metricbeat] Release Golang module as GA.

[ruflin]

• Add integration tests. Use metricbeat as Golang example app.
• Add data.json

[jsoriano]

It LGTM, but I'd suggest to use a smaller image, or would it be an option to start an http listener with pprof in the test itself?

[ruflin]

I'm getting the following error on CI:

01-29T09:37:34.087Z\tWARN\ttransport/tcp.go:53\tDNS lookup failure "golang": lookup golang on 127.0.0.11:53: no such host\n2019-01-29T09:37:34.088Z\tDEBUG\t[publisher]\tpipeline/processor.go:305\tPublish event: {\n  "@timestamp": "2019-01-29T09:37:34.044Z",\n  "@metadata": {\n    "beat": "metricbeat",\n    "type": "_doc",\n    "version": "7.0.0"\n  },\n  "agent": {\n    "id": "eca3e1b9-16b5-4009-83bf-057a137dbe35",\n    "version": "7.0.0",\n    "type": "metricbeat",\n    "ephemeral_id": "844e0bd2-24e7-4cef-b653-16b2744c23e7",\n    "hostname": "b4604df432a9"\n  },\n  "metricset": {\n    "name": "heap"\n  },\n  "service": {\n    "address": "golang:6060",\n    "type": "golang"\n  },\n  "error": {\n    "message": "error making http request: Get http://golang:6060/debug/vars: lookup golang on 127.0.0.11:53: no such host"\n  },\n  "event": {\n    "dataset": "golang.heap",\n    "module": "golang",\n    "duration": 43325852\n  },\n  "host": {\n    "name": "b4604df432a9"\n  },\n  "ecs": {\n    "version": "1.0.0-beta2"\n  }\n}\n

I wonder if the healthcheck is wrong or not waiting long enough. At the same time there seems to be something odd with the host?

[ruflin]

@jsoriano Not sure if I have to make this change because of #10367 Seems to have worked a few days ago without the dot. No deal breaker.

[jsoriano]

Yes, this is related for sure 🙁 I'll make "" to behave as "." for BC.

[jsoriano]

#10402

[ruflin]

For some reason it seems the http pprof endpoint and starts and stops again inside the container.

[jsoriano]

Failing tests are related

[ruflin]

Yes, and I can't really figure out what happens :-(

[jsoriano]

@ruflin GOLANG_HOST has a value now and it is used in test_golang.py for the listening address. I think this should be replaced by 0.0.0.0 (or localhost):

        proc = self.start_beat(
            extra_args=[
                "-httpprof",
                "0.0.0.0" +
                ":" +
                os.getenv(
                    'GOLANG_PORT',
                    '6060')])

[ruflin]

@jsoriano Exactly what I was looking for. For now I event set it to localhost only as this should work as the system tests run on the same machine as the binary itself, so no external access needed 🤞