[Metricbeat] Move redis.info metricset to ECS #10319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
webmat
reviewed
Jan 24, 2019
metricbeat/docs/modules/aws.asciidoc
Outdated
| @@ -33,6 +33,9 @@ see https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp.html[Te | |||
| aws> sts get-session-token --serial-number arn:aws:iam::1234:mfa/test@elastic.co --token-code 456789 --duration-seconds 129600 | |||
| ---- | |||
|
|
|||
| Specific permissions needs to be added into the IAM user's policy to allow Metricbeat collecting AWS monitoring metrics. Please | |||
There was a problem hiding this comment.
"to allow Metricbeat collecting" => "to authorize Metricbeat to collect", or something to that effect?
There was a problem hiding this comment.
And directly below, "metric set" => "metricset"?
There was a problem hiding this comment.
That was a left over which made it in this PR. Rebase will remove this part.
@kaiyan-sheng That is for you ^
kaiyan-sheng
approved these changes
Jan 25, 2019
ruflin
changed the title
|
Ready for review. |
webmat
changed the title
webmat
changed the title
webmat
approved these changes
Jan 25, 2019
| beat: metricbeat | ||
|
|
||
| - from: redis.info.server.os | ||
| to: os.full |
There was a problem hiding this comment.
Right, if the service is remote, can't put under host.os. Agreed.
I like at the top level like this (rather than at service.os)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.